mirror of
https://github.com/golang/go
synced 2024-11-19 11:24:51 -07:00
4c83a7e07a
Expressing regtests in terms of textual coordinates is hard to read: the reader ends up counting lines and characters to understand the text edit or assertion. To address, this, add two new functions for fake.Editor: RegexpSearch and RegexpReplace, as well as a symmetric RegexpSearch function for workspace files and wrappers for regtext.Env. This allows expressing edits as well as buffer locations in terms of easily scannable regexps. An alternative solution to this problem is to integrate markers ala packagestest. I tried this, but it ended up being cumbersome to implement and less usable than regexps, due to the static nature of markers: after the buffer has been edited all markers must be updated. Updates golang/go#36879 Change-Id: Iad087cf0d529737034197beef7b729816a159c69 Reviewed-on: https://go-review.googlesource.com/c/tools/+/224757 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
132 lines
3.5 KiB
Go
132 lines
3.5 KiB
Go
// Copyright 2020 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package fake
|
|
|
|
import (
|
|
"fmt"
|
|
"sort"
|
|
"strings"
|
|
|
|
"golang.org/x/tools/internal/lsp/protocol"
|
|
)
|
|
|
|
// Pos represents a position in a text buffer. Both Line and Column are
|
|
// 0-indexed.
|
|
type Pos struct {
|
|
Line, Column int
|
|
}
|
|
|
|
func (p Pos) toProtocolPosition() protocol.Position {
|
|
return protocol.Position{
|
|
Line: float64(p.Line),
|
|
Character: float64(p.Column),
|
|
}
|
|
}
|
|
|
|
func fromProtocolPosition(pos protocol.Position) Pos {
|
|
return Pos{
|
|
Line: int(pos.Line),
|
|
Column: int(pos.Character),
|
|
}
|
|
}
|
|
|
|
// Edit represents a single (contiguous) buffer edit.
|
|
type Edit struct {
|
|
Start, End Pos
|
|
Text string
|
|
}
|
|
|
|
// NewEdit creates an edit replacing all content between
|
|
// (startLine, startColumn) and (endLine, endColumn) with text.
|
|
func NewEdit(startLine, startColumn, endLine, endColumn int, text string) Edit {
|
|
return Edit{
|
|
Start: Pos{Line: startLine, Column: startColumn},
|
|
End: Pos{Line: endLine, Column: endColumn},
|
|
Text: text,
|
|
}
|
|
}
|
|
|
|
func (e Edit) toProtocolChangeEvent() protocol.TextDocumentContentChangeEvent {
|
|
return protocol.TextDocumentContentChangeEvent{
|
|
Range: &protocol.Range{
|
|
Start: e.Start.toProtocolPosition(),
|
|
End: e.End.toProtocolPosition(),
|
|
},
|
|
Text: e.Text,
|
|
}
|
|
}
|
|
|
|
func fromProtocolTextEdit(textEdit protocol.TextEdit) Edit {
|
|
return Edit{
|
|
Start: fromProtocolPosition(textEdit.Range.Start),
|
|
End: fromProtocolPosition(textEdit.Range.End),
|
|
Text: textEdit.NewText,
|
|
}
|
|
}
|
|
|
|
// inText reports whether p is a valid position in the text buffer.
|
|
func inText(p Pos, content []string) bool {
|
|
if p.Line < 0 || p.Line >= len(content) {
|
|
return false
|
|
}
|
|
// Note the strict right bound: the column indexes character _separators_,
|
|
// not characters.
|
|
if p.Column < 0 || p.Column > len([]rune(content[p.Line])) {
|
|
return false
|
|
}
|
|
return true
|
|
}
|
|
|
|
// editContent implements a simplistic, inefficient algorithm for applying text
|
|
// edits to our buffer representation. It returns an error if the edit is
|
|
// invalid for the current content.
|
|
func editContent(content []string, edits []Edit) ([]string, error) {
|
|
newEdits := make([]Edit, len(edits))
|
|
copy(newEdits, edits)
|
|
sort.Slice(newEdits, func(i, j int) bool {
|
|
if newEdits[i].Start.Line < newEdits[j].Start.Line {
|
|
return true
|
|
}
|
|
if newEdits[i].Start.Line > newEdits[j].Start.Line {
|
|
return false
|
|
}
|
|
return newEdits[i].Start.Column < newEdits[j].Start.Column
|
|
})
|
|
|
|
// Validate edits.
|
|
for _, edit := range newEdits {
|
|
if edit.End.Line < edit.Start.Line || (edit.End.Line == edit.Start.Line && edit.End.Column < edit.Start.Column) {
|
|
return nil, fmt.Errorf("invalid edit: end %v before start %v", edit.End, edit.Start)
|
|
}
|
|
if !inText(edit.Start, content) {
|
|
return nil, fmt.Errorf("start position %v is out of bounds", edit.Start)
|
|
}
|
|
if !inText(edit.End, content) {
|
|
return nil, fmt.Errorf("end position %v is out of bounds", edit.End)
|
|
}
|
|
}
|
|
|
|
var (
|
|
b strings.Builder
|
|
line, column int
|
|
)
|
|
advance := func(toLine, toColumn int) {
|
|
for ; line < toLine; line++ {
|
|
b.WriteString(string([]rune(content[line])[column:]) + "\n")
|
|
column = 0
|
|
}
|
|
b.WriteString(string([]rune(content[line])[column:toColumn]))
|
|
column = toColumn
|
|
}
|
|
for _, edit := range newEdits {
|
|
advance(edit.Start.Line, edit.Start.Column)
|
|
b.WriteString(edit.Text)
|
|
line = edit.End.Line
|
|
column = edit.End.Column
|
|
}
|
|
advance(len(content)-1, len([]rune(content[len(content)-1])))
|
|
return strings.Split(b.String(), "\n"), nil
|
|
}
|