mirror of
https://github.com/golang/go
synced 2024-11-05 17:36:15 -07:00
f895b43688
This removes much of the AST logic out of main.go, and makes it easier to build custom vet binaries The trade-off in this change is for flexibility. There's very little change in the per-check files, a lot less code in main.go (specifically the AST walking logic has shrunk), and it makes it much easier to build custom vet binaries simply by dropping new source files in the directory. LGTM=josharian, r R=r, josharian, kamil.kisiel CC=golang-codereviews https://golang.org/cl/83400043
69 lines
1.4 KiB
Go
69 lines
1.4 KiB
Go
// Copyright 2013 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
/*
|
|
This file contains the code to check for useless function comparisons.
|
|
A useless comparison is one like f == nil as opposed to f() == nil.
|
|
*/
|
|
|
|
package main
|
|
|
|
import (
|
|
"go/ast"
|
|
"go/token"
|
|
|
|
"code.google.com/p/go.tools/go/types"
|
|
)
|
|
|
|
func init() {
|
|
register("nilfunc",
|
|
"check for comparisons between functions and nil",
|
|
checkNilFuncComparison,
|
|
binaryExpr)
|
|
}
|
|
|
|
func checkNilFuncComparison(f *File, node ast.Node) {
|
|
e := node.(*ast.BinaryExpr)
|
|
|
|
// Only want == or != comparisons.
|
|
if e.Op != token.EQL && e.Op != token.NEQ {
|
|
return
|
|
}
|
|
|
|
// Only want comparisons with a nil identifier on one side.
|
|
var e2 ast.Expr
|
|
switch {
|
|
case f.isNil(e.X):
|
|
e2 = e.Y
|
|
case f.isNil(e.Y):
|
|
e2 = e.X
|
|
default:
|
|
return
|
|
}
|
|
|
|
// Only want identifiers or selector expressions.
|
|
var obj types.Object
|
|
switch v := e2.(type) {
|
|
case *ast.Ident:
|
|
obj = f.pkg.uses[v]
|
|
case *ast.SelectorExpr:
|
|
obj = f.pkg.uses[v.Sel]
|
|
default:
|
|
return
|
|
}
|
|
|
|
// Only want functions.
|
|
if _, ok := obj.(*types.Func); !ok {
|
|
return
|
|
}
|
|
|
|
f.Badf(e.Pos(), "comparison of function %v %v nil is always %v", obj.Name(), e.Op, e.Op == token.NEQ)
|
|
}
|
|
|
|
// isNil reports whether the provided expression is the built-in nil
|
|
// identifier.
|
|
func (f *File) isNil(e ast.Expr) bool {
|
|
return f.pkg.types[e].Type == types.Typ[types.UntypedNil]
|
|
}
|