cc02d59e84
golang.org/cl/284138 introduced a regression: running "gofmt foo" would silently ignore the file due to its lack of a ".go" extension, whereas the tool is documented otherwise: Given a file, it operates on that file; given a directory, it operates on all .go files in that directory, recursively. This wasn't caught as there were no tests for these edge cases. gofmt's own tests are regular Go tests, so it's hard to test it properly without adding an abstraction layer on top of func main. Luckily, this kind of test is a great fit for cmd/go's own script tests, and it just takes a few straightforward lines. Finally, add the relevant logic back, with documentation to clarify its intentional purpose. Fixes #45859. Change-Id: Ic5bf5937b8f95fcdad2b6933227c8b504ef38a82 Reviewed-on: https://go-review.googlesource.com/c/go/+/315270 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> Trust: Daniel Martí <mvdan@mvdan.cc> Trust: Robert Griesemer <gri@golang.org> Trust: Bryan C. Mills <bcmills@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com> |
||
---|---|---|
.github | ||
api | ||
doc | ||
lib/time | ||
misc | ||
src | ||
test | ||
.gitattributes | ||
.gitignore | ||
AUTHORS | ||
codereview.cfg | ||
CONTRIBUTING.md | ||
CONTRIBUTORS | ||
LICENSE | ||
PATENTS | ||
README.md | ||
SECURITY.md |
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://golang.org/doc/contribute.html.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.