Rebecca Stambler 37a045f3b9 internal/lsp: move undeclaredname suggested fix out of analysis ... This CL is a follow-up from CL 241983. I didn't realize that the undeclaredname analysis was also using the go/printer.Fprint trick, which we decided was both incorrect and inefficient. This CL does approximately the same things as CL 241983, with a few changes to make the approach more general. source.Analyzer now has a field to indicate if its suggested fix needs to be computed separately, and that is used to determine which code actions get commands. We also make helper functions to map analyses to their commands. I figured out a neater way to test suggested fixes in this CL, so I reversed the move to source_test back to lsp_test (which was the right place all along). Change-Id: I505bf4790481d887edda8b82897e541ec73fb427 Reviewed-on: https://go-review.googlesource.com/c/tools/+/242366 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>		2020-07-23 23:54:27 +00:00
..
code_lens.go	internal/lsp: separate test and benchmark codelens	2020-07-22 18:17:40 +00:00
comment_test.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
comment.go	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
completion_builtin.go	internal/lsp: remove Ignore feature	2020-06-11 22:55:14 +00:00
completion_format.go	internal/lsp/source: speed up completion candidate formatting	2020-07-01 04:11:22 +00:00
completion_keywords.go	internal/lsp/source: offer loop keyword completions in range stmt	2020-03-12 04:57:24 +00:00
completion_labels.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
completion_literal.go	internal/telemetry: renaming to internal/event	2020-04-23 17:20:48 +00:00
completion_snippet.go	internal/lsp: merge completion options into source.Options	2020-01-13 20:09:44 +00:00
completion_statements.go	internal/lsp/source: offer smart "append()" completions	2020-05-20 22:05:37 +00:00
completion.go	internal/lsp: extract highlighted selection to variable	2020-07-07 21:12:28 +00:00
deep_completion.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
diagnostics.go	internal/lsp: refactor go.mod diagnostics to simplify the API	2020-07-16 22:50:03 +00:00
extract.go	internal/lsp: support extract function	2020-07-20 18:55:41 +00:00
folding_range.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
format_test.go	internal/lsp: avoid panic caused by assuming file ends with newline	2020-07-14 19:07:37 +00:00
format.go	internal/lsp: log errors for compute fix edits instead of returning	2020-07-17 02:25:49 +00:00
highlight.go	internal/lsp/source: support highlight of switch statements	2020-06-19 02:36:21 +00:00
hover.go	internal/lsp: add a configuration to enable/disable links in hover	2020-07-17 02:43:01 +00:00
identifier.go	internal/lsp: fix error in CL 242457	2020-07-16 17:41:35 +00:00
implementation.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
options.go	internal/lsp: move undeclaredname suggested fix out of analysis	2020-07-23 23:54:27 +00:00
references.go	internal/event: renaming the main event API functions	2020-04-23 17:21:36 +00:00
rename_check.go	internal/lsp: add changeMethods logic to rename check	2020-07-13 19:50:33 +00:00
rename.go	internal/lsp: add changeMethods logic to rename check	2020-07-13 19:50:33 +00:00
signature_help.go	internal/lsp/source: speed up completion candidate formatting	2020-07-01 04:11:22 +00:00
source_test.go	internal/lsp: move undeclaredname suggested fix out of analysis	2020-07-23 23:54:27 +00:00
suggested_fix.go	internal/lsp: move undeclaredname suggested fix out of analysis	2020-07-23 23:54:27 +00:00
symbols.go	internal/lsp: use %w in error wrappers	2020-05-04 14:52:14 +00:00
types_format.go	internal/lsp/source: handle nil pointer in newBuiltinSignature	2020-07-15 19:52:07 +00:00
util.go	internal/lsp: change the way that we pass arguments to command	2020-07-21 16:30:27 +00:00
view.go	internal/lsp: move undeclaredname suggested fix out of analysis	2020-07-23 23:54:27 +00:00
workspace_symbol.go	internal/lsp/source: add a new symbolStyle configuration option	2020-06-26 17:13:37 +00:00