Rebecca Stambler 37a045f3b9 internal/lsp: move undeclaredname suggested fix out of analysis ... This CL is a follow-up from CL 241983. I didn't realize that the undeclaredname analysis was also using the go/printer.Fprint trick, which we decided was both incorrect and inefficient. This CL does approximately the same things as CL 241983, with a few changes to make the approach more general. source.Analyzer now has a field to indicate if its suggested fix needs to be computed separately, and that is used to determine which code actions get commands. We also make helper functions to map analyses to their commands. I figured out a neater way to test suggested fixes in this CL, so I reversed the move to source_test back to lsp_test (which was the right place all along). Change-Id: I505bf4790481d887edda8b82897e541ec73fb427 Reviewed-on: https://go-review.googlesource.com/c/tools/+/242366 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>		2020-07-23 23:54:27 +00:00
..
fillreturns	internal/lsp/analysis/fillreturns: implement matching in fillreturns	2020-06-11 16:18:57 +00:00
fillstruct	internal/lsp: move fillstruct suggested fixes out of analysis	2020-07-20 20:42:44 +00:00
nonewvars	internal/lsp: add type error fixes to existing diagnostics	2020-04-08 01:45:16 +00:00
noresultvalues	internal/lsp: add type error fixes to existing diagnostics	2020-04-08 01:45:16 +00:00
simplifycompositelit	internal/lsp: make sure that gofmt -s analyses don't modify AST	2020-04-06 21:01:14 +00:00
simplifyrange	internal/lsp: make sure that gofmt -s analyses don't modify AST	2020-04-06 21:01:14 +00:00
simplifyslice	internal/lsp: make sure that gofmt -s analyses don't modify AST	2020-04-06 21:01:14 +00:00
undeclaredname	internal/lsp: move undeclaredname suggested fix out of analysis	2020-07-23 23:54:27 +00:00
unusedparams	internal/lsp: move undeclaredname suggested fix out of analysis	2020-07-23 23:54:27 +00:00