caf96f7dae
This CL converts the last call to scope.LookupParent with no position information to a check.lookup call that respects position information provided by Eval (there's one more LookupParent call that cannot be converted, see the respective comment in the code). In this case, the lookup is needed to determine the variable on the LHS of an assignment, for adjustment of its `used` information. Outside a types.Eval call, i.e., during normal type-checking, there is no difference between this new code and the old code. While in a types.Eval call, it's important to use the correct position to look up the relevant variable. If token.NoPos were used, one might find another variable with the same name, declared later in the scope. Caveat: Types.Eval only accepts expressions, and it's currently not possible to evaluate assignments (except via function literals, but then the scope is different). That is, this change is a fix for a potential future bug, and for now a no-op. Change-Id: I28db1fe1202c07e3f7b3fadfd185728afb9b2ae7 Reviewed-on: https://go-review.googlesource.com/85199 Reviewed-by: Alan Donovan <adonovan@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| favicon.ico | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| robots.txt | ||
| VERSION | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Contributing
Go is the work of hundreds of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.