mirror of
https://github.com/golang/go
synced 2024-10-05 02:31:21 -06:00
473441fc30
I've been writing some code which involves syncing files (like rsync) and it became apparent that under Linux I could read modification times (os.Lstat) with nanosecond precision but only write them with microsecond precision. This difference in precision is rather annoying when trying to discover whether files need syncing or not! I've patched syscall and os to increases the accuracy of of os.Chtimes for Linux and Windows. This involved exposing the utimensat system call under Linux and a bit of extra code under Windows. I decided not to expose the "at" bit of the system call as it is impossible to replicate under Windows, so the patch adds syscall.Utimens() to all architectures along with a ImplementsUtimens flag. If the utimensat syscall isn't available (utimensat was added to Linux in 2.6.22, Released, 8 July 2007) then it silently falls back to the microsecond accuracy version it uses now. The improved accuracy for Windows should be good for all versions of Windows. Unfortunately Darwin doesn't seem to have a utimensat system call that I could find so I couldn't implement it there. The BSDs do, but since they share their syscall implementation with Darwin I couldn't figure out how to define a syscall for *BSD and not Darwin. I've left this as a TODO in the code. In the process I implemented the missing methods for Timespec under Windows which I needed which just happened to round out the Timespec API for all platforms! ------------------------------------------------------------ Test code: http://play.golang.org/p/1xnGuYOi4b Linux Before (1000 ns precision) $ ./utimetest.linux.before z Setting mtime 1344937903123456789: 2012-08-14 10:51:43.123456789 +0100 BST Reading mtime 1344937903123457000: 2012-08-14 10:51:43.123457 +0100 BST Linux After (1 ns precision) $ ./utimetest.linux.after z Setting mtime 1344937903123456789: 2012-08-14 10:51:43.123456789 +0100 BST Reading mtime 1344937903123456789: 2012-08-14 10:51:43.123456789 +0100 BST Windows Before (1000 ns precision) X:\>utimetest.windows.before.exe c:\Test.txt Setting mtime 1344937903123456789: 2012-08-14 10:51:43.123456789 +0100 GMTDT Reading mtime 1344937903123456000: 2012-08-14 10:51:43.123456 +0100 GMTDT Windows After (100 ns precision) X:\>utimetest.windows.after.exe c:\Test.txt Setting mtime 1344937903123456789: 2012-08-14 10:51:43.123456789 +0100 GMTDT Reading mtime 1344937903123456700: 2012-08-14 10:51:43.1234567 +0100 GMTDT R=golang-dev, alex.brainman, rsc, bradfitz CC=golang-dev https://golang.org/cl/6905057 |
||
|---|---|---|
| .. | ||
| asm_darwin_386.s | ||
| asm_darwin_amd64.s | ||
| asm_freebsd_386.s | ||
| asm_freebsd_amd64.s | ||
| asm_freebsd_arm.s | ||
| asm_linux_386.s | ||
| asm_linux_amd64.s | ||
| asm_linux_arm.s | ||
| asm_netbsd_386.s | ||
| asm_netbsd_amd64.s | ||
| asm_openbsd_386.s | ||
| asm_openbsd_amd64.s | ||
| asm_plan9_386.s | ||
| asm_plan9_amd64.s | ||
| asm_windows_386.s | ||
| asm_windows_amd64.s | ||
| bpf_bsd.go | ||
| creds_test.go | ||
| dir_plan9.go | ||
| dll_windows.go | ||
| env_plan9.go | ||
| env_unix.go | ||
| env_windows.go | ||
| exec_bsd.go | ||
| exec_linux.go | ||
| exec_plan9.go | ||
| exec_unix.go | ||
| exec_windows.go | ||
| lsf_linux.go | ||
| mkall.sh | ||
| mkerrors_windows.sh | ||
| mkerrors.sh | ||
| mksyscall_windows.pl | ||
| mksyscall.pl | ||
| mksysctl_openbsd.pl | ||
| mksysnum_darwin.pl | ||
| mksysnum_freebsd.pl | ||
| mksysnum_linux.pl | ||
| mksysnum_netbsd.pl | ||
| mksysnum_openbsd.pl | ||
| mksysnum_plan9.sh | ||
| netlink_linux.go | ||
| passfd_test.go | ||
| race0.go | ||
| race.go | ||
| route_bsd.go | ||
| route_darwin.go | ||
| route_freebsd.go | ||
| route_netbsd.go | ||
| route_openbsd.go | ||
| security_windows.go | ||
| sockcmsg_linux.go | ||
| sockcmsg_unix.go | ||
| str.go | ||
| syscall_bsd.go | ||
| syscall_darwin_386.go | ||
| syscall_darwin_amd64.go | ||
| syscall_darwin.go | ||
| syscall_freebsd_386.go | ||
| syscall_freebsd_amd64.go | ||
| syscall_freebsd_arm.go | ||
| syscall_freebsd.go | ||
| syscall_linux_386.go | ||
| syscall_linux_amd64.go | ||
| syscall_linux_arm.go | ||
| syscall_linux.go | ||
| syscall_netbsd_386.go | ||
| syscall_netbsd_amd64.go | ||
| syscall_netbsd.go | ||
| syscall_openbsd_386.go | ||
| syscall_openbsd_amd64.go | ||
| syscall_openbsd.go | ||
| syscall_plan9_386.go | ||
| syscall_plan9_amd64.go | ||
| syscall_plan9.go | ||
| syscall_unix.go | ||
| syscall_windows_386.go | ||
| syscall_windows_amd64.go | ||
| syscall_windows_test.go | ||
| syscall_windows.go | ||
| syscall.go | ||
| types_darwin.go | ||
| types_freebsd.go | ||
| types_linux.go | ||
| types_netbsd.go | ||
| types_openbsd.go | ||
| types_plan9.c | ||
| zerrors_darwin_386.go | ||
| zerrors_darwin_amd64.go | ||
| zerrors_freebsd_386.go | ||
| zerrors_freebsd_amd64.go | ||
| zerrors_freebsd_arm.go | ||
| zerrors_linux_386.go | ||
| zerrors_linux_amd64.go | ||
| zerrors_linux_arm.go | ||
| zerrors_netbsd_386.go | ||
| zerrors_netbsd_amd64.go | ||
| zerrors_openbsd_386.go | ||
| zerrors_openbsd_amd64.go | ||
| zerrors_plan9_386.go | ||
| zerrors_plan9_amd64.go | ||
| zerrors_windows_386.go | ||
| zerrors_windows_amd64.go | ||
| zerrors_windows.go | ||
| zsyscall_darwin_386.go | ||
| zsyscall_darwin_amd64.go | ||
| zsyscall_freebsd_386.go | ||
| zsyscall_freebsd_amd64.go | ||
| zsyscall_freebsd_arm.go | ||
| zsyscall_linux_386.go | ||
| zsyscall_linux_amd64.go | ||
| zsyscall_linux_arm.go | ||
| zsyscall_netbsd_386.go | ||
| zsyscall_netbsd_amd64.go | ||
| zsyscall_openbsd_386.go | ||
| zsyscall_openbsd_amd64.go | ||
| zsyscall_plan9_386.go | ||
| zsyscall_plan9_amd64.go | ||
| zsyscall_windows_386.go | ||
| zsyscall_windows_amd64.go | ||
| zsysctl_openbsd.go | ||
| zsysnum_darwin_386.go | ||
| zsysnum_darwin_amd64.go | ||
| zsysnum_freebsd_386.go | ||
| zsysnum_freebsd_amd64.go | ||
| zsysnum_freebsd_arm.go | ||
| zsysnum_linux_386.go | ||
| zsysnum_linux_amd64.go | ||
| zsysnum_linux_arm.go | ||
| zsysnum_netbsd_386.go | ||
| zsysnum_netbsd_amd64.go | ||
| zsysnum_openbsd_386.go | ||
| zsysnum_openbsd_amd64.go | ||
| zsysnum_plan9_386.go | ||
| zsysnum_plan9_amd64.go | ||
| zsysnum_windows_386.go | ||
| zsysnum_windows_amd64.go | ||
| ztypes_darwin_386.go | ||
| ztypes_darwin_amd64.go | ||
| ztypes_freebsd_386.go | ||
| ztypes_freebsd_amd64.go | ||
| ztypes_freebsd_arm.go | ||
| ztypes_linux_386.go | ||
| ztypes_linux_amd64.go | ||
| ztypes_linux_arm.go | ||
| ztypes_netbsd_386.go | ||
| ztypes_netbsd_amd64.go | ||
| ztypes_openbsd_386.go | ||
| ztypes_openbsd_amd64.go | ||
| ztypes_plan9_386.go | ||
| ztypes_plan9_amd64.go | ||
| ztypes_windows_386.go | ||
| ztypes_windows_amd64.go | ||
| ztypes_windows.go | ||