1
0
mirror of https://github.com/golang/go synced 2024-11-18 16:54:43 -07:00
go/internal/lsp/cache
Heschi Kreinick ca43edf915 internal/lsp/cache: intermediate test variants aren't workspace packages
When you write a test in (say) the fmt package, you get a test variant
augmented with the test files. In many cases you also get test variants
of the things the fmt package depends on. The primary test variant,
(fmt [fmt.test]) is interesting to us, because it contains the tests.
But the intermediate variants (testing [fmt.test]) aren't -- the user
can only get to them indirectly. We certainly don't need to fully parse
them.

Treat intermediate test variants as non-workspace packages. This doesn't
accomplish much yet but paves the way for later optimizations.

Updates golang/go#36943.

Change-Id: I1a20abcd2d67767f07132a75a20f098be6f19a76
Reviewed-on: https://go-review.googlesource.com/c/tools/+/236397
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-11 22:26:57 +00:00
..
analysis.go internal/lsp: fix caching issue with duplicate handles 2020-05-07 19:23:25 +00:00
cache.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
check.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
error_test.go internal/lsp: refactor error handling code in type-checking 2019-10-21 18:57:46 +00:00
errors.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
keys.go internal/lsp: decouple client and server debug 2020-06-11 13:49:48 +00:00
load.go internal/lsp/cache: intermediate test variants aren't workspace packages 2020-06-11 22:26:57 +00:00
mod.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
os_darwin.go internal/lsp: add a mutex around the view's options 2020-04-02 16:41:49 +00:00
os_windows.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
parse.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
pkg.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
session.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
snapshot.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
view_test.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
view.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00