mirror of
https://github.com/golang/go
synced 2024-11-24 00:30:15 -07:00
301f6c8019
We currently make dictionaries contain a relocation pointing to methods that generic code might use, so that those methods are not deadcode eliminated. However, with inlining we can end up not using the dictionary, making the reference from the dictionary to the method no longer keep the method alive. Fix this by keeping the dictionary alive at generic interface call sites. It's a bit of overkill, as we only need to keep the dictionary statically alive. We don't actually need it dynamically alive, which is what KeepAlive does. But it works. It ends up generating a LEAQ + stack spill that aren't necessary, but that's pretty low overhead. To make this work, I needed to stop generating methods on shape types. We should do this anyway, as we shouldn't ever need them. But currently we do use them! issue44688.go has a test that only works because it calls a method on a shape type. I've disabled that test for now, will work on it in a subsequent CL. Fixes #48047 Change-Id: I78968868d6486c1745f51b8b43be0898931432a2 Reviewed-on: https://go-review.googlesource.com/c/go/+/349169 Trust: Keith Randall <khr@golang.org> Trust: Dan Scales <danscales@google.com> Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Dan Scales <danscales@google.com> Reviewed-by: Than McIntosh <thanm@google.com>
31 lines
441 B
Go
31 lines
441 B
Go
// run -gcflags=-G=3
|
|
|
|
// Copyright 2021 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
type A[T any] struct {
|
|
field B[T]
|
|
}
|
|
|
|
type B[T any] interface {
|
|
Work(T)
|
|
}
|
|
|
|
func (a *A[T]) Work(t T) {
|
|
a.field.Work(t)
|
|
}
|
|
|
|
type BImpl struct{}
|
|
|
|
func (b BImpl) Work(s string) {}
|
|
|
|
func main() {
|
|
a := &A[string]{
|
|
field: BImpl{},
|
|
}
|
|
a.Work("")
|
|
}
|