Rob Findley 9a0fabac01 internal/lsp: fix errors found by staticcheck ... While experimenting with different static analysis on x/tools, I noticed that there are many actionable diagnostics found by staticcheck. Fix the ones that were not false positives. Change-Id: I0b68cf1f636b57b557db879fad84fff9b7237a89 Reviewed-on: https://go-review.googlesource.com/c/tools/+/222248 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-03-19 19:20:54 +00:00
..
apidiff	all: fix more typos	2019-09-11 15:13:14 +00:00
fastwalk	internal/fastwalk: fix checkptr failure on Darwin	2020-02-27 19:33:42 +00:00
gocommand	x/tools/gopls: run go generate through CodeLens	2020-03-17 04:34:34 +00:00
gopathwalk	internal: rationalize debug logging	2020-03-03 16:59:18 +00:00
imports	internal/imports: don't set a logger unless the user has provided it	2020-03-03 21:46:25 +00:00
jsonrpc2	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
lsp	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
memoize	internal/lsp/debug: serve cache entry counts	2020-02-03 22:21:18 +00:00
packagesinternal	internal/lsp: add module versions from "go list" to pkg.go.dev links	2020-02-19 19:55:21 +00:00
span	internal/span: handle URI escaping better	2020-02-18 20:59:02 +00:00
telemetry	internal/telemetry: add type safe tag keys	2020-03-18 13:29:43 +00:00
testenv	internal/testenv: reject the resolved 'go' command if it does not match runtime.GOROOT	2019-11-11 19:22:22 +00:00
tool	internal/tool: avoid editorialization	2020-03-05 14:01:59 +00:00
xcontext	internal/lsp: stop making background contexts everywhere	2019-07-11 16:38:52 +00:00