c9591d73ef
type T [3]string Prior to this change, we generated this equality alg for T: func eqT(p, q *T) (r bool) { for i := range *p { if len(p[i]) == len(q[i]) { } else { return } } for j := range *p { if runtime.memeq(p[j].ptr, q[j].ptr, len(p[j])) { } else { return } } return true } That first loop can be profitably eliminated; it's cheaper to spell out 3 length equality checks. We now generate: func eqT(p, q *T) (r bool) { if len(p[0]) == len(q[0]) && len(p[1]) == len(q[1]) && len(p[2]) == len(q[2]) { } else { return } for i := 0; i < len(p); i++ { if runtime.memeq(p[j].ptr, q[j].ptr, len(p[j])) { } else { return } } return true } We now also eliminate loops for small float arrays as well, and for any array of size 1. These cutoffs were selected to minimize code size on amd64 at this moment, for lack of a more compelling methodology. Any smallish number would do. The switch from range loops to plain for loops allowed me to use a temp instead of a named var, which eliminated a pointless argument to checkAll. The code to construct them is also a bit clearer, in my opinion. Change-Id: I1bdd8ee4a2739d00806e66b17a4e76b46e71231a Reviewed-on: https://go-review.googlesource.com/c/go/+/230210 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org> |
||
---|---|---|
.github | ||
api | ||
doc | ||
lib/time | ||
misc | ||
src | ||
test | ||
.gitattributes | ||
.gitignore | ||
AUTHORS | ||
CONTRIBUTING.md | ||
CONTRIBUTORS | ||
favicon.ico | ||
LICENSE | ||
PATENTS | ||
README.md | ||
robots.txt | ||
SECURITY.md |
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.