1
0
mirror of https://github.com/golang/go synced 2024-11-24 03:20:02 -07:00
go/src
Dan Scales c8d6ee12d5 cmd/compile: match Go 1.17 compiler error messages more closely
When being used by the compiler, fix up types2 error messages to be more
like Go 1.17 compiler errors. In particular:

  - add information about which method is missing when a type is not
    assignable/convertible/etc. to an interface.

  - add information about any existing method which has the same name,
    but wrong type.

  - add extra hint in the case that the source or destination type is a
    pointer to an interface, rather than an interface.

  - add extra hint "need type assertion" in the case that the source is
    an interface that is implemented by the destination.

  - the following change in the CL stack also adds information about any
    existing method with a different name that only differs in case.

Include much of the new logic in a new common function
(*Checker).missingMethodReason().

types2 still adds a little more information in some cases then the Go
1.17 compiler. For example, it typically says "(value of type T)",
rather than "(type T)", where "value" could also be "constant",
"variable", etc.

I kept the types2 error messages almost all the same when types2 is not
used by the compiler. The only change (to reduce amount of compatibility
code) was to change "M method" phrasing in one case to "method M"
phrasing in one error message (which is the phrasing it uses in all
other cases). That is the reason that there are a few small changes in
types2/testdata/check/*.src.

Added new test test/fixedbugs/issue48471.go to test that the added
information is appearing correctly.

Also adjusted the pattern matching in a bunch of other
test/fixedbugs/*.go, now that types2 is producing error messages closer
to Go 1.17. Was able to remove a couple test files from the types2
exception list in run.go.

Updated #48471

Change-Id: I8af1eae6eb8a5541d8ea20b66f494e2e795e1956
Reviewed-on: https://go-review.googlesource.com/c/go/+/363436
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
2021-11-12 23:07:01 +00:00
..
archive archive/zip: don't read data descriptor early 2021-11-07 04:56:11 +00:00
bufio bufio: document that NewWriter can return its argument 2021-11-09 20:06:10 +00:00
builtin
bytes strings, bytes: deprecate Title 2021-11-05 21:27:34 +00:00
cmd cmd/compile: match Go 1.17 compiler error messages more closely 2021-11-12 23:07:01 +00:00
compress
constraints
container
context
crypto crypto/x509: remove ios build tag restriction 2021-11-08 17:46:34 +00:00
database/sql database/sql: prevent closes slices from assigning to free conn 2021-11-11 19:46:03 +00:00
debug all: remove more leftover // +build lines 2021-11-06 10:24:44 +00:00
embed go/build: skip rune literals when looking for go:embed 2021-11-11 20:25:49 +00:00
encoding encoding/xml: add generic encoding test 2021-11-09 21:26:25 +00:00
errors errors: add errors.Unwrap example 2021-11-05 21:28:50 +00:00
expvar
flag
fmt
go go/types: re-use type hashing logic in Context.typeHash 2021-11-12 18:11:51 +00:00
hash
html
image
index/suffixarray
internal internal/fuzz: set timeout for each exec of fuzz target 2021-11-12 18:48:59 +00:00
io io: add error check to TeeReader Example 2021-11-11 19:34:23 +00:00
log
math math/bits: add examples for Add, Sub, Mul and Div 2021-11-11 21:27:05 +00:00
mime mime: keep parsing after trailing semicolon 2021-11-09 22:58:24 +00:00
net net/http: do not cancel request context on response body read 2021-11-12 20:20:57 +00:00
os os: clarify that File.{Read,Write} use the buffer 2021-11-09 20:08:48 +00:00
path
plugin
reflect reflect: keep pointer in aggregate-typed args live in Call 2021-11-12 14:56:58 +00:00
regexp
runtime runtime: start ARM atomic kernel helper traceback in caller 2021-11-12 21:06:35 +00:00
sort
strconv
strings strings, bytes: deprecate Title 2021-11-05 21:27:34 +00:00
sync sync: clarify the validity to call Map methods inside Range 2021-11-11 04:41:56 +00:00
syscall all: remove more leftover // +build lines 2021-11-06 10:24:44 +00:00
testdata
testing all: update terminology for fuzzing 2021-11-11 21:06:07 +00:00
text
time lib/time, time/tzdata: update to 2021e 2021-11-11 05:16:39 +00:00
unicode unicode/utf8: add AppendRune Example 2021-11-05 21:29:18 +00:00
unsafe
vendor all: update vendored golang.org/x/crypto for Go 1.18 release 2021-11-09 20:10:44 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update vendored golang.org/x/crypto for Go 1.18 release 2021-11-09 20:10:44 +00:00
go.sum all: update vendored golang.org/x/crypto for Go 1.18 release 2021-11-09 20:10:44 +00:00
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.