1
0
mirror of https://github.com/golang/go synced 2024-10-01 04:18:33 -06:00
go/internal/lsp/source
Heschi Kreinick c81e7ae886 internal/lsp/source: unify import adding code
We used to need our own copy of astutil.AddNamedImport to use during
completion for a variety of reasons, but I think the major one was
needing to not format the whole file. The same problem applied to using
the imports package.

Happily, that was resolved in CL 205678. Now we can use the same
implementation on both paths. In addition to removing a bunch of code,
that means that unimported completions now add their imports in the
right place, respecting goimports grouping and the local configuration
setting.

Fixes golang/go#35519.

Change-Id: I693c2e8b5ced9bac62b1febf1e2db23c770e5a7a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/206881
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-11-12 22:26:51 +00:00
..
comment_test.go internal/lsp: convert comments to markdown before sending to client 2019-10-04 18:35:38 +00:00
comment.go internal/lsp: convert comments to markdown before sending to client 2019-10-04 18:35:38 +00:00
completion_format.go internal/lsp/source: unify import adding code 2019-11-12 22:26:51 +00:00
completion_keywords.go internal/lsp: add some keyword completions 2019-10-22 20:49:18 +00:00
completion_labels.go internal/lsp: fix label completion in range and type switch stmts 2019-10-22 21:33:09 +00:00
completion_literal.go internal/lsp: improve literal func completion candidates 2019-11-07 21:18:00 +00:00
completion_snippet.go internal/lsp: don't overwrite suffix when inserting completion 2019-10-02 20:07:45 +00:00
completion.go internal/lsp/source: unify import adding code 2019-11-12 22:26:51 +00:00
deep_completion.go internal/lsp/source: attach Package to completions when available 2019-11-05 20:21:09 +00:00
diagnostics.go internal/lsp: remove analyzers from Analyze result 2019-10-25 02:35:17 +00:00
errors.go internal/lsp: move the missing imports handling into the metadata 2019-09-25 23:05:17 +00:00
folding_range.go internal/lsp: rework snapshots and cache FileHandles per-snapshot 2019-10-01 16:26:22 +00:00
format.go internal/lsp/source: unify import adding code 2019-11-12 22:26:51 +00:00
highlight.go internal/lsp: stop cluttering logs with highlight errors 2019-10-07 17:20:23 +00:00
hover.go internal/lsp: don't associate package with snapshot 2019-10-23 20:24:04 +00:00
identifier.go internal/lsp: remove the pkg.view field, in preparation for CL 204079 2019-10-29 23:14:01 +00:00
implementation.go internal/lsp: support implementations requests for implementations in other packages 2019-11-12 18:49:59 +00:00
options.go internal/lsp: add config flag to hide debugging output 2019-11-05 20:43:22 +00:00
references.go internal/lsp: remove the pkg.view field, in preparation for CL 204079 2019-10-29 23:14:01 +00:00
rename_check.go internal/lsp: improve literal func completion candidates 2019-11-07 21:18:00 +00:00
rename.go internal/lsp: remove the pkg.view field, in preparation for CL 204079 2019-10-29 23:14:01 +00:00
signature_help.go internal/lsp: remove the pkg.view field, in preparation for CL 204079 2019-10-29 23:14:01 +00:00
source_test.go tools/gopls: add cmd support for folding_ranges 2019-11-12 00:55:09 +00:00
suggested_fix.go internal/lsp: move error range computations into cache package 2019-10-21 22:12:58 +00:00
symbols.go internal/lsp: stop caching diagnostics on the package 2019-10-24 22:03:59 +00:00
tidy.go internal/lsp: support running go mod tidy as a code action 2019-09-20 13:08:46 +00:00
util.go internal/lsp: remove the pkg.view field, in preparation for CL 204079 2019-10-29 23:14:01 +00:00
view.go internal/lsp: support implementations requests for implementations in other packages 2019-11-12 18:49:59 +00:00