Rebecca Stambler c7475b9d7f internal/lsp/source: refactor highlighting code ... The current implementation has a number of helper functions that have to thread through context, errors, converters, etc. Simplify the code by factoring out the conversion to a protocol range into a final step. There are probably further improvements that can be made too. As part of debugging, I noticed that the cmdtest server does not get shutdown once tests finish, which leads to excessive logging. Is closing the test server connection enough to trigger shutdowns? It doesn't seem to be. Change-Id: Ia67666f6b8debccd120795bb24bd089620c0a87b Reviewed-on: https://go-review.googlesource.com/c/tools/+/238377 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>		2020-06-18 15:59:44 +00:00
..
code_lens.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
comment_test.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
comment.go	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
completion_builtin.go	internal/lsp: remove Ignore feature	2020-06-11 22:55:14 +00:00
completion_format.go	internal/lsp: honor GOPRIVATE in documentLinks and go.mod hovers	2020-06-18 13:42:42 +00:00
completion_keywords.go	internal/lsp/source: offer loop keyword completions in range stmt	2020-03-12 04:57:24 +00:00
completion_labels.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
completion_literal.go	internal/telemetry: renaming to internal/event	2020-04-23 17:20:48 +00:00
completion_snippet.go	internal/lsp: merge completion options into source.Options	2020-01-13 20:09:44 +00:00
completion_statements.go	internal/lsp/source: offer smart "append()" completions	2020-05-20 22:05:37 +00:00
completion.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
deep_completion.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
diagnostics.go	internal/lsp: plumb fillstruct through analysis	2020-06-15 21:22:08 +00:00
folding_range.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
format_test.go	internal/lsp: fix new bug duplicating comments after includes	2020-05-19 20:57:26 +00:00
format.go	internal/lsp: cancel the initial workspace load when view shuts down	2020-06-12 18:06:40 +00:00
highlight.go	internal/lsp/source: refactor highlighting code	2020-06-18 15:59:44 +00:00
hover.go	internal/lsp: honor GOPRIVATE in documentLinks and go.mod hovers	2020-06-18 13:42:42 +00:00
identifier.go	internal/lsp: remove Ignore feature	2020-06-11 22:55:14 +00:00
implementation.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
options.go	internal/lsp: plumb fillstruct through analysis	2020-06-15 21:22:08 +00:00
references.go	internal/event: renaming the main event API functions	2020-04-23 17:21:36 +00:00
rename_check.go	internal/lsp/source: avoid panic in rename check	2020-06-16 19:50:46 +00:00
rename.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
signature_help.go	internal/lsp: use %w in error wrappers	2020-05-04 14:52:14 +00:00
source_test.go	internal/lsp: honor GOPRIVATE in documentLinks and go.mod hovers	2020-06-18 13:42:42 +00:00
symbols.go	internal/lsp: use %w in error wrappers	2020-05-04 14:52:14 +00:00
types_format.go	internal/lsp: remove Ignore feature	2020-06-11 22:55:14 +00:00
util.go	internal/lsp: remove Ignore feature	2020-06-11 22:55:14 +00:00
view.go	internal/lsp: use a new temporary go.mod for every go list call	2020-06-18 02:37:23 +00:00
workspace_symbol.go	internal/lsp: add config option for SymbolMatch	2020-05-11 19:58:58 +00:00