1
0
mirror of https://github.com/golang/go synced 2024-11-24 10:00:12 -07:00
go/src
LE Manh Cuong c5f142fa9f cmd/compile: optimize bitset tests
The assembly output for x & c == c, where c is power of 2:

	MOVQ	"".set+8(SP), AX
	ANDQ	$8, AX
	CMPQ	AX, $8
	SETEQ	"".~r2+24(SP)

With optimization using bitset:

	MOVQ	"".set+8(SP), AX
	BTL	$3, AX
	SETCS	"".~r2+24(SP)

output less than 1 instruction.

However, there is no speed improvement:

name         old time/op  new time/op  delta
AllBitSet-8  0.35ns ± 0%  0.35ns ± 0%   ~     (all equal)

Fixes #31904

Change-Id: I5dca4e410bf45716ed2145e3473979ec997e35d4
Reviewed-on: https://go-review.googlesource.com/c/go/+/175957
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
2019-08-27 18:01:16 +00:00
..
archive archive/zip: remove unused special case 2019-08-27 17:00:43 +00:00
bufio
builtin
bytes bytes: remove obsolete comment 2019-05-28 02:52:39 +00:00
cmd cmd/compile: optimize bitset tests 2019-08-27 18:01:16 +00:00
compress
container
context all: remove os.ErrTimeout 2019-08-02 17:57:18 +00:00
crypto crypto/x509: add Ed25519 to ExampleParsePKIXPublicKey 2019-07-29 16:52:01 +00:00
database/sql
debug
encoding encoding/json: remove unnecessary isValidNumber call 2019-08-27 17:53:55 +00:00
errors errors: document Is and As methods 2019-08-27 16:51:42 +00:00
expvar all: change some function documentation to be more idiomatic 2019-07-28 18:09:57 +00:00
flag
fmt doc/go1.13: document fmt's number syntax updates 2019-08-23 23:40:29 +00:00
go go/types: process each segment of delayed actions in FIFO order 2019-08-26 17:14:41 +00:00
hash
html html/template: micro optimization for isJSType 2019-08-27 17:41:33 +00:00
image
index/suffixarray
internal reflect: optimize directlyAssignable to avoid rtype.Name call 2019-08-27 16:44:22 +00:00
io
log
math
mime
net Revert "net/url: fail TestParseErrors test when getting an unwanted error" 2019-08-27 17:25:52 +00:00
os os: change Readdirnames doc to follow that of Readdir 2019-08-02 21:52:01 +00:00
path path: fix mismatch between error message and corresponding test function 2019-08-08 00:38:10 +00:00
plugin
reflect reflect: optimize directlyAssignable to avoid rtype.Name call 2019-08-27 16:44:22 +00:00
regexp
runtime runtime/pprof: Mention goroutine label heritability 2019-08-07 14:40:17 +00:00
sort
strconv strconv: simplify the text for bases in ParseInt 2019-08-23 00:46:55 +00:00
strings strings: clarify usage of Title and ToTitle 2019-07-30 02:52:57 +00:00
sync
syscall syscall: document relationship among Errno, errors.Is and os.Err* 2019-08-22 20:06:29 +00:00
testdata
testing Revert "cmd/go: move automatic testing.Init call into generated test code" 2019-07-22 21:42:51 +00:00
text text/template: avoid allocating a new common in copy 2019-08-27 16:56:26 +00:00
time time: update TestSub to avoid future regressions 2019-08-16 19:54:57 +00:00
unicode
unsafe
vendor net/http: update bundled golang.org/x/net/http2 to import security fix 2019-08-23 17:03:17 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod net/http: update bundled golang.org/x/net/http2 to import security fix 2019-08-23 17:03:17 +00:00
go.sum net/http: update bundled golang.org/x/net/http2 to import security fix 2019-08-23 17:03:17 +00:00
iostest.bash
make.bash
make.bat
Make.dist
make.rc
naclmake.bash
nacltest.bash all: use consistent shebang line across all shell scripts 2018-08-22 16:41:11 +00:00
race.bash
race.bat
README.vendor all: update 'go get' command in standard library README.vendor 2019-08-23 21:07:49 +00:00
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.