qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 08:14:41 -07:00
Code Releases Activity
c537a342dd
go/internal/lsp
History
Rebecca Stambler c537a342dd internal/lsp: pass options by reference instead of by value 
We were previously behaving as though the slice/map values in the
options struct could be modified directly. The options should be cloned
before modification. Also, convert any usage of source.Options to
*source.Options.

Fixes golang/go#39592

Change-Id: Ib39f668bca0fa1038162206bd7793fd2049af576
Reviewed-on: https://go-review.googlesource.com/c/tools/+/254558
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
2020-09-16 22:53:23 +00:00
..
analysis internal/lsp/analysis: update fillreturns title 2020-09-08 15:52:18 +00:00
browser
cache internal/lsp: pass options by reference instead of by value 2020-09-16 22:53:23 +00:00
cmd internal/lsp: pass options by reference instead of by value 2020-09-16 22:53:23 +00:00
debug internal/lsp: fix builds and tests for go1.12+ 2020-08-27 14:30:46 +00:00
diff internal/testenv: check that external 'diff' tool is the GNU version 2020-05-08 20:46:49 +00:00
fake internal/lsp: enable multi-module workspace mode by default in tests 2020-09-15 20:16:39 +00:00
fuzzy internal/lsp/fuzzy: fix return value on no match 2020-08-28 15:37:48 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/lsp/lsprpc: make the LSP forwarder exit error clearer 2020-09-01 17:31:45 +00:00
mod internal/lsp: pass options by reference instead of by value 2020-09-16 22:53:23 +00:00
protocol internal/lsp/protocol: add support for upcoming LSP 3.16 2020-09-11 12:00:08 +00:00
snippet
source internal/lsp: pass options by reference instead of by value 2020-09-16 22:53:23 +00:00
testdata internal/lsp: break up fillstruct testdata to make it more manageable 2020-09-08 20:59:11 +00:00
tests internal/lsp: enable multi-module workspace mode by default in tests 2020-09-15 20:16:39 +00:00
call_hierarchy.go internal/lsp: release resources for call hierarchy file requests 2020-08-07 21:04:51 +00:00
code_action.go internal/lsp: handle staticcheck in code actions 2020-09-14 16:17:55 +00:00
code_lens.go gopls/doc: generate settings JSON, docs 2020-09-09 20:53:33 +00:00
command.go internal/lsp: use -json for module upgrades 2020-09-01 17:31:32 +00:00
completion_test.go internal/lsp: pass options by reference instead of by value 2020-09-16 22:53:23 +00:00
completion.go internal/lsp: pass options by reference instead of by value 2020-09-16 22:53:23 +00:00
definition.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
diagnostics.go internal/lsp: add support for RelatedInformation in diagnostics 2020-09-04 18:57:47 +00:00
folding_range.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
format.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
general.go internal/lsp: pass options by reference instead of by value 2020-09-16 22:53:23 +00:00
highlight.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
hover.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
implementation.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
link.go internal/lsp: enable multi-module workspace mode by default in tests 2020-09-15 20:16:39 +00:00
lsp_test.go internal/lsp: pass options by reference instead of by value 2020-09-16 22:53:23 +00:00
progress_test.go internal/lsp: improvements for command messages 2020-08-21 20:07:30 +00:00
progress.go internal/lsp: improvements for command messages 2020-08-21 20:07:30 +00:00
references.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
rename.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
reset_golden.sh
server_gen.go internal/lsp/protocol: add support for upcoming LSP 3.16 2020-09-11 12:00:08 +00:00
server.go internal/lsp/protocol: add support for upcoming LSP 3.16 2020-09-11 12:00:08 +00:00
signature_help.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
symbols.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
text_synchronization.go internal/lsp: check file kind before showing warning 2020-09-15 03:16:44 +00:00
workspace_symbol.go internal/lsp/source: add a new symbolStyle configuration option 2020-06-26 17:13:37 +00:00
workspace.go internal/lsp: pass options by reference instead of by value 2020-09-16 22:53:23 +00:00