mirror of
https://github.com/golang/go
synced 2024-11-17 20:04:47 -07:00
0efbd10157
Use the following (suboptimal) script to obtain a list of possible typos: #!/usr/bin/env sh set -x git ls-files |\ grep -e '\.\(c\|cc\|go\)$' |\ xargs -n 1\ awk\ '/\/\// { gsub(/.*\/\//, ""); print; } /\/\*/, /\*\// { gsub(/.*\/\*/, ""); gsub(/\*\/.*/, ""); }' |\ hunspell -d en_US -l |\ grep '^[[:upper:]]\{0,1\}[[:lower:]]\{1,\}$' |\ grep -v -e '^.\{1,4\}$' -e '^.\{16,\}$' |\ sort -f |\ uniq -c |\ awk '$1 == 1 { print $2; }' Then, go through the results manually and fix the most obvious typos in the non-vendored code. Change-Id: I3cb5830a176850e1a0584b8a40b47bde7b260eae Reviewed-on: https://go-review.googlesource.com/c/go/+/193848 Reviewed-by: Robert Griesemer <gri@golang.org>
87 lines
2.1 KiB
Go
87 lines
2.1 KiB
Go
// +build amd64
|
|
// errorcheck -0 -d=ssa/likelyadjust/debug=1,ssa/insert_resched_checks/off
|
|
// rescheduling check insertion is turned off because the inserted conditional branches perturb the errorcheck
|
|
|
|
// Copyright 2016 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test that branches have some prediction properties.
|
|
package foo
|
|
|
|
func f(x, y, z int) int {
|
|
a := 0
|
|
for i := 0; i < x; i++ { // ERROR "Branch prediction rule stay in loop"
|
|
for j := 0; j < y; j++ { // ERROR "Branch prediction rule stay in loop"
|
|
a += j
|
|
}
|
|
for k := 0; k < z; k++ { // ERROR "Branch prediction rule stay in loop"
|
|
a -= x + y + z
|
|
}
|
|
}
|
|
return a
|
|
}
|
|
|
|
func g(x, y, z int) int {
|
|
a := 0
|
|
if y == 0 { // ERROR "Branch prediction rule default < call"
|
|
y = g(y, z, x)
|
|
} else {
|
|
y++
|
|
}
|
|
if y == x { // ERROR "Branch prediction rule default < call"
|
|
y = g(y, z, x)
|
|
} else {
|
|
}
|
|
if y == 2 { // ERROR "Branch prediction rule default < call"
|
|
z++
|
|
} else {
|
|
y = g(z, x, y)
|
|
}
|
|
if y+z == 3 { // ERROR "Branch prediction rule call < exit"
|
|
println("ha ha")
|
|
} else {
|
|
panic("help help help")
|
|
}
|
|
if x != 0 { // ERROR "Branch prediction rule default < ret"
|
|
for i := 0; i < x; i++ { // ERROR "Branch prediction rule stay in loop"
|
|
if x == 4 { // ERROR "Branch prediction rule stay in loop"
|
|
return a
|
|
}
|
|
for j := 0; j < y; j++ { // ERROR "Branch prediction rule stay in loop"
|
|
for k := 0; k < z; k++ { // ERROR "Branch prediction rule stay in loop"
|
|
a -= j * i
|
|
}
|
|
a += j
|
|
}
|
|
}
|
|
}
|
|
return a
|
|
}
|
|
|
|
func h(x, y, z int) int {
|
|
a := 0
|
|
for i := 0; i < x; i++ { // ERROR "Branch prediction rule stay in loop"
|
|
for j := 0; j < y; j++ { // ERROR "Branch prediction rule stay in loop"
|
|
a += j
|
|
if i == j { // ERROR "Branch prediction rule stay in loop"
|
|
break
|
|
}
|
|
a *= j
|
|
}
|
|
for k := 0; k < z; k++ { // ERROR "Branch prediction rule stay in loop"
|
|
a -= k
|
|
if i == k {
|
|
continue
|
|
}
|
|
a *= k
|
|
}
|
|
}
|
|
if a > 0 { // ERROR "Branch prediction rule default < call"
|
|
a = g(x, y, z)
|
|
} else {
|
|
a = -a
|
|
}
|
|
return a
|
|
}
|