Rob Findley c4d4ea9c79 internal/lsp/cache: return concrete types where possible ... For testability, and to allow the exchange of debug information when forwarding the LSP, it will be necessary to access debug information stored in cache objects. This is cumbersome to do if our constructors return source interfaces rather than concrete types. This CL changes cache.New and (*Cache).NewSession to return concrete types. This required removing NewSession from source.Cache. I would argue that this makes sense from a philosophical perspective: everything in the source package operates in a context where the Session and Cache already exist. Updates golang/go#34111 Change-Id: I01721db827d51117f9479f1544b15cedae0c5921 Reviewed-on: https://go-review.googlesource.com/c/tools/+/220077 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-02-19 18:42:16 +00:00
..
comment_test.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
comment.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
completion_builtin.go	internal/lsp/source: improve completion for "make()" args	2020-02-02 23:20:50 +00:00
completion_format.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00
completion_keywords.go	internal/lsp: sort by label after score	2019-12-30 21:11:21 +00:00
completion_labels.go	internal/lsp: sort by label after score	2019-12-30 21:11:21 +00:00
completion_literal.go	internal/lsp: fix crash completing recursive pointer types	2020-02-07 22:44:06 +00:00
completion_snippet.go	internal/lsp: merge completion options into source.Options	2020-01-13 20:09:44 +00:00
completion.go	internal/lsp/source: handle completing into variadic params	2020-02-14 18:12:26 +00:00
deep_completion.go	internal/lsp/source: improve completion involving multiple return values	2020-02-06 05:07:08 +00:00
diagnostics.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
errors.go	internal/lsp: remove the checkErrors command in internal/lsp/source	2020-01-24 21:19:55 +00:00
folding_range.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
format_test.go	internal/lsp/source: trim file very carefully	2020-01-17 20:34:13 +00:00
format.go	internal/lsp: fix diagnostics not clearing when creating new files	2020-02-13 21:50:53 +00:00
highlight.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
hover.go	internal/lsp/source: export FindFileInpackage	2020-02-07 21:55:11 +00:00
identifier.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
implementation.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00
options.go	internal/lsp: add codelens for go.mod dependency upgrades	2020-02-14 14:15:08 +00:00
references.go	internal/lsp: don't return references for builtins	2020-02-06 19:49:06 +00:00
rename_check.go	internal/lsp: improve literal func completion candidates	2019-11-07 21:18:00 +00:00
rename.go	internal/lsp: permit renaming symbols declared in other packages	2020-01-27 18:56:10 +00:00
signature_help.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
source_test.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00
symbols.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
util.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00
view.go	internal/lsp/cache: return concrete types where possible	2020-02-19 18:42:16 +00:00
workspace_symbol.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00