go/test at c4b65fa4cc4b799cad461779564af30dbf232f13 - go

qbit/go

mirror of https://github.com/golang/go synced 2024-11-23 05:40:04 -07:00

History

Hugues Bruant c4b65fa4cc cmd/compile: inline closures with captures When inlining a closure with captured variables, walk up the param chain to find the one that is defined inside the scope into which the function is being inlined, and map occurrences of the captures to temporary inlvars, similarly to what is done for function parameters. No noticeable impact on compilation speed and binary size. Minor improvements to go1 benchmarks on darwin/amd64 name old time/op new time/op delta BinaryTree17-4 2.59s ± 3% 2.58s ± 1% ~ (p=0.470 n=19+19) Fannkuch11-4 3.15s ± 2% 3.15s ± 1% ~ (p=0.647 n=20+19) FmtFprintfEmpty-4 43.7ns ± 3% 43.4ns ± 4% ~ (p=0.178 n=18+20) FmtFprintfString-4 74.0ns ± 2% 77.1ns ± 7% +4.13% (p=0.000 n=20+20) FmtFprintfInt-4 77.2ns ± 3% 79.2ns ± 6% +2.53% (p=0.000 n=20+20) FmtFprintfIntInt-4 112ns ± 4% 112ns ± 2% ~ (p=0.672 n=20+19) FmtFprintfPrefixedInt-4 136ns ± 1% 135ns ± 2% ~ (p=0.827 n=16+20) FmtFprintfFloat-4 232ns ± 2% 233ns ± 1% ~ (p=0.194 n=20+20) FmtManyArgs-4 490ns ± 2% 484ns ± 2% -1.28% (p=0.001 n=20+20) GobDecode-4 6.68ms ± 2% 6.72ms ± 2% ~ (p=0.113 n=20+19) GobEncode-4 5.62ms ± 2% 5.71ms ± 2% +1.64% (p=0.000 n=20+19) Gzip-4 235ms ± 3% 236ms ± 2% ~ (p=0.607 n=20+19) Gunzip-4 37.1ms ± 2% 36.8ms ± 3% ~ (p=0.060 n=20+20) HTTPClientServer-4 61.9µs ± 2% 62.7µs ± 4% +1.24% (p=0.007 n=18+19) JSONEncode-4 12.5ms ± 2% 12.4ms ± 3% ~ (p=0.192 n=20+20) JSONDecode-4 51.6ms ± 3% 51.0ms ± 3% -1.19% (p=0.008 n=20+19) Mandelbrot200-4 4.12ms ± 6% 4.06ms ± 5% ~ (p=0.063 n=20+20) GoParse-4 3.12ms ± 5% 3.10ms ± 2% ~ (p=0.402 n=19+19) RegexpMatchEasy0_32-4 80.7ns ± 2% 75.1ns ± 9% -6.94% (p=0.000 n=17+20) RegexpMatchEasy0_1K-4 197ns ± 2% 186ns ± 2% -5.43% (p=0.000 n=20+20) RegexpMatchEasy1_32-4 77.5ns ± 4% 71.9ns ± 7% -7.25% (p=0.000 n=20+18) RegexpMatchEasy1_1K-4 341ns ± 3% 341ns ± 3% ~ (p=0.732 n=20+20) RegexpMatchMedium_32-4 113ns ± 2% 112ns ± 3% ~ (p=0.102 n=20+20) RegexpMatchMedium_1K-4 36.6µs ± 2% 35.8µs ± 2% -2.26% (p=0.000 n=18+20) RegexpMatchHard_32-4 1.75µs ± 3% 1.74µs ± 2% ~ (p=0.473 n=20+19) RegexpMatchHard_1K-4 52.6µs ± 2% 52.0µs ± 3% -1.15% (p=0.005 n=20+20) Revcomp-4 381ms ± 4% 377ms ± 2% ~ (p=0.067 n=20+18) Template-4 57.3ms ± 2% 57.7ms ± 2% ~ (p=0.108 n=20+20) TimeParse-4 291ns ± 3% 292ns ± 2% ~ (p=0.585 n=20+20) TimeFormat-4 314ns ± 3% 315ns ± 1% ~ (p=0.681 n=20+20) [Geo mean] 47.4µs 47.1µs -0.73% name old speed new speed delta GobDecode-4 115MB/s ± 2% 114MB/s ± 2% ~ (p=0.115 n=20+19) GobEncode-4 137MB/s ± 2% 134MB/s ± 2% -1.63% (p=0.000 n=20+19) Gzip-4 82.5MB/s ± 3% 82.4MB/s ± 2% ~ (p=0.612 n=20+19) Gunzip-4 523MB/s ± 2% 528MB/s ± 3% ~ (p=0.060 n=20+20) JSONEncode-4 155MB/s ± 2% 156MB/s ± 3% ~ (p=0.192 n=20+20) JSONDecode-4 37.6MB/s ± 3% 38.1MB/s ± 3% +1.21% (p=0.007 n=20+19) GoParse-4 18.6MB/s ± 4% 18.7MB/s ± 2% ~ (p=0.405 n=19+19) RegexpMatchEasy0_32-4 396MB/s ± 2% 426MB/s ± 8% +7.56% (p=0.000 n=17+20) RegexpMatchEasy0_1K-4 5.18GB/s ± 2% 5.48GB/s ± 2% +5.79% (p=0.000 n=20+20) RegexpMatchEasy1_32-4 413MB/s ± 4% 444MB/s ± 6% +7.46% (p=0.000 n=20+19) RegexpMatchEasy1_1K-4 3.00GB/s ± 3% 3.00GB/s ± 3% ~ (p=0.678 n=20+20) RegexpMatchMedium_32-4 8.82MB/s ± 2% 8.90MB/s ± 3% +0.99% (p=0.044 n=20+20) RegexpMatchMedium_1K-4 28.0MB/s ± 2% 28.6MB/s ± 2% +2.32% (p=0.000 n=18+20) RegexpMatchHard_32-4 18.3MB/s ± 3% 18.4MB/s ± 2% ~ (p=0.482 n=20+19) RegexpMatchHard_1K-4 19.5MB/s ± 2% 19.7MB/s ± 3% +1.18% (p=0.004 n=20+20) Revcomp-4 668MB/s ± 4% 674MB/s ± 2% ~ (p=0.066 n=20+18) Template-4 33.8MB/s ± 2% 33.6MB/s ± 2% ~ (p=0.104 n=20+20) [Geo mean] 124MB/s 126MB/s +1.54% Updates #15561 Updates #18270 Change-Id: I980086efe28b36aa27f81577065e2a729ff03d4e Reviewed-on: https://go-review.googlesource.com/72490 Reviewed-by: Hugues Bruant <hugues.bruant@gmail.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org>		2017-11-05 04:18:05 +00:00
..
alias3.dir
bench	test/bench/go1: fix typo in parserdata_test.go comment	2017-03-22 03:23:16 +00:00
chan	all: fix article typos	2017-09-15 02:39:16 +00:00
closure3.dir	cmd/compile: inline closures with captures	2017-11-05 04:18:05 +00:00
ddd2.dir
dwarf
fixedbugs	cmd/compile: inline closures with captures	2017-11-05 04:18:05 +00:00
import2.dir
import4.dir
interface	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
intrinsic.dir	cmd/compile: intrinsics for math/bits.TrailingZerosX	2017-03-16 02:44:16 +00:00
ken
linkname.dir
method4.dir
safe
stress
syntax
uintptrescapes.dir
64bit.go
235.go
alg.go
alias1.go
alias2.go
alias3.go
alias.go
append1.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
append.go
args.go
armimm.go	cmd/internal/obj: continue to optimize ARM's constant pool	2017-05-11 13:53:54 +00:00
assign1.go
assign.go
atomicload.go
bigalg.go
bigmap.go
blank1.go
blank.go
bom.go
bombad.go
bounds.go
chancap.go	cmd/compile: generate makechan calls with int arguments	2017-08-15 05:54:24 +00:00
chanlinear.go
char_lit1.go
char_lit.go
checkbce.go	test: add missing copyright header to checkbce.go	2017-05-18 00:05:25 +00:00
clearfat.go
closedchan.go
closure1.go
closure2.go
closure3.go	cmd/compile: fix reassignment check	2017-11-03 20:09:26 +00:00
closure.go
cmp6.go
cmp.go
cmplx.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
cmplxdivide1.go
cmplxdivide.c
cmplxdivide.go
complit1.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
complit.go
compos.go
const1.go
const2.go
const3.go
const4.go
const5.go
const6.go
const.go
convert1.go
convert2.go
convert3.go
convert.go
convlit1.go
convlit.go
convT2X.go
copy1.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
copy.go
crlf.go
ddd1.go	test: reenable ... test	2017-08-11 17:41:17 +00:00
ddd2.go
ddd.go
decl.go
declbad.go
defer.go
deferfin.go
deferprint.go
deferprint.out
devirt.go
divide.go
divmod.go
empty.go
env.go
eof1.go
eof.go
errchk
escape2.go	test: add missing escape analysis test	2017-08-11 00:56:21 +00:00
escape2n.go	test: add missing escape analysis test	2017-08-11 00:56:21 +00:00
escape3.go
escape4.go	cmd/compile: inline calls to local closures	2017-10-11 22:32:36 +00:00
escape5.go	cmd/compile: unnamed parameters do not escape	2017-03-24 17:14:00 +00:00
escape_array.go
escape_because.go
escape_calls.go
escape_closure.go
escape_field.go
escape_iface.go
escape_indir.go
escape_level.go
escape_map.go
escape_param.go
escape_slice.go
escape_struct_param1.go
escape_struct_param2.go
escape_struct_return.go
escape.go
fibo.go
finprofiled.go
float_lit2.go
float_lit3.go
float_lit.go
floatcmp.go
for.go
func1.go
func2.go
func3.go
func4.go
func5.go
func6.go
func7.go
func8.go
func.go
funcdup2.go
funcdup.go
gc1.go
gc2.go
gc.go
gcstring.go
goprint.go
goprint.out
goto.go	cmd/compile: report block start for gotos jumping into blocks	2017-04-19 02:27:58 +00:00
heapsampling.go
helloworld.go
helloworld.out
if.go
import1.go
import2.go
import4.go
import5.go	cmd/compile: be slightly more tolerant in case of certain syntax errors	2017-03-24 20:07:15 +00:00
import6.go
import.go
index0.go
index1.go
index2.go
index.go
indirect1.go
indirect.go
init1.go
init.go
initcomma.go
initialize.go
initializerr.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
initloop.go
inline_caller.go	runtime: skip logical frames in runtime.Caller	2017-04-18 19:56:30 +00:00
inline_callers.go	cmd/go: switch to entirely content-based staleness determination	2017-10-31 13:19:38 +00:00
inline_literal.go
inline_variadic.go
inline.go	cmd/compile: inline closures with captures	2017-11-05 04:18:05 +00:00
int_lit.go
intcvt.go
intrinsic_atomic.go	cmd/compile: intrinsify atomics on MIPS64	2017-10-10 19:43:38 +00:00
intrinsic.go
iota.go
label1.go	cmd/compile/internal/gc: don't panic on continue in switch	2017-04-12 14:27:45 +00:00
label.go
linkmain_run.go
linkmain.go
linkname.go
linkobj.go
linkx_run.go
linkx.go
literal.go
live1.go
live2.go	cmd/compile: specialize map creation for small hint sizes	2017-11-02 17:03:45 +00:00
live_syscall.go
live.go	cmd/compile: specialize map creation for small hint sizes	2017-11-02 17:03:45 +00:00
locklinear.go	test: deflake locklinear again	2017-04-05 18:46:31 +00:00
loopbce.go	cmd/compile: make loop guard+rotate conditional on GOEXPERIMENT	2017-06-21 22:07:33 +00:00
makechan.go	cmd/compile: generate makechan calls with int arguments	2017-08-15 05:54:24 +00:00
makemap.go	cmd/compile: generate makemap calls with int arguments	2017-08-22 20:28:21 +00:00
makenew.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
mallocfin.go
map1.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
map.go
maplinear.go
mergemul.go	cmd/compile: combine xn - yn into (x-y)*n	2017-09-03 14:29:38 +00:00
method1.go
method2.go	cmd/compile: add two error position tests for the typechecker	2017-10-12 20:50:20 +00:00
method3.go
method4.go
method5.go
method6.go	cmd/compile: add two error position tests for the typechecker	2017-10-12 20:50:20 +00:00
method7.go	test: add test cases for method expressions with literal receiver types	2017-10-26 03:47:37 +00:00
method.go
named1.go
named.go
nil.go
nilcheck.go
nilptr2.go
nilptr3.go	cmd/compile: remove more nil ptr checks after newobject	2017-08-25 03:26:58 +00:00
nilptr4.go
nilptr.go
nosplit.go	test: fix and re-enable nosplit.go	2017-10-31 19:12:11 +00:00
notinheap2.go
notinheap3.go	cmd/compile: elide write barriers for copy of notinheap pointers	2017-10-29 20:21:49 +00:00
notinheap.go
nowritebarrier.go	cmd/compile: improve coverage of nowritebarrierrec check	2017-10-29 19:36:44 +00:00
nul1.go
opt_branchlikely.go
parentype.go
peano.go
phiopt.go
print.go	cmd/compile: fix print/println when input is uint	2017-09-26 04:08:38 +00:00
print.out	cmd/compile: fix print/println when input is uint	2017-09-26 04:08:38 +00:00
printbig.go
printbig.out
prove.go	cmd/compile/internal/gc: improve comparison with constant strings	2017-04-07 15:40:25 +00:00
range.go	cmd/compile: improve single blank variable handling in walkrange	2017-09-12 05:50:54 +00:00
README.md	test: add README	2017-07-26 23:37:25 +00:00
recover1.go
recover2.go
recover3.go
recover4.go
recover5.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
recover.go
reflectmethod1.go
reflectmethod2.go
reflectmethod3.go
reflectmethod4.go
rename1.go	cmd/compile: avoid duplicate cast error	2017-08-22 13:44:35 +00:00
rename.go
reorder2.go
reorder.go
return.go
rotate0.go
rotate1.go
rotate2.go
rotate3.go
rotate.go
run.go	test/run: use go tool compile + link instead of go run when possible	2017-10-31 13:21:05 +00:00
rune.go
runtime.go
shift1.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
shift2.go
sieve.go
sigchld.go
sigchld.out
simassign.go
sinit_run.go
sinit.go
sizeof.go
slice3.go
slice3err.go
slicecap.go
sliceopt.go
solitaire.go
stack.go
strength.go
string_lit.go
stringrange.go
struct0.go
switch2.go
switch3.go
switch4.go
switch5.go	cmd/compile: make duplicate expr cases readable	2017-05-19 18:11:51 +00:00
switch6.go
switch7.go	cmd/compile: make duplicate expr cases readable	2017-05-19 18:11:51 +00:00
switch.go
tinyfin.go
torture.go
turing.go
typecheck.go
typecheckloop.go
typeswitch1.go
typeswitch2.go
typeswitch3.go	cmd/compile: add test for non interface type switch	2017-03-25 22:52:54 +00:00
typeswitch.go
uintptrescapes2.go
uintptrescapes.go
undef.go
utf.go
varerr.go
varinit.go
writebarrier.go	cmd/compile: don't use statictmps for SSA-able composite literals	2017-05-11 18:28:40 +00:00
zerodivide.go

README.md

The test directory contains tests of the Go tool chain and runtime. It includes black box tests, regression tests, and error output tests. They are run as part of all.bash.

To run just these tests, execute:

go run run.go

Standard library tests should be written as regular Go tests in the appropriate package.

The tool chain and runtime also have regular Go tests in their packages. The main reasons to add a new test to this directory are:

it is most naturally expressed using the test runner; or
it is also applicable to gccgo and other Go tool chains.