1
0
mirror of https://github.com/golang/go synced 2024-09-30 20:08:32 -06:00
go/internal/lsp/source
Muir Manders c42aa19e51 internal/lsp/source: improve unnamed type completion
Tweak a few things so that unnamed, non-basic types are offered as
completions in certain cases:

    var _ []int = make(<>) // now properly suggests "[]int"

I also fixed type related keywords to not be offered if there is an
expected type:

    var _ *int = new(<>) // don't offer "func", etc.

There are still some cases that don't work properly. For example:

    var _ [][]int = make([]<>) // doesn't offer "[]int"

This would be harder to fix given the way things currently work.

Fixes golang/go#40275, golang/go#40274.

Change-Id: I2577d5863d4757845ad3ff7dbb125106b649a6b6
Reviewed-on: https://go-review.googlesource.com/c/tools/+/246360
Run-TryBot: Muir Manders <muir@mnd.rs>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-08-12 23:05:10 +00:00
..
call_hierarchy.go internal/lsp: fix a few small staticcheck warnings 2020-08-11 03:20:01 +00:00
code_lens.go internal/lsp: add "run file benchmarks" code lens 2020-08-12 18:37:58 +00:00
command.go internal/lsp: fix bug in extract function when highlighting full line 2020-08-07 18:02:56 +00:00
comment_test.go internal/lsp: convert comments to markdown before sending to client 2019-10-04 18:35:38 +00:00
comment.go internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
completion_builtin.go internal/lsp/source: improve unnamed type completion 2020-08-12 23:05:10 +00:00
completion_format.go internal/lsp: remove source.Cache 2020-08-05 22:08:24 +00:00
completion_keywords.go internal/lsp/source: improve unnamed type completion 2020-08-12 23:05:10 +00:00
completion_labels.go internal/lsp: use one context throughout completion 2020-04-06 16:51:37 +00:00
completion_literal.go internal/lsp/source: simplify variadic logic in completion 2020-08-06 02:28:45 +00:00
completion_snippet.go internal/lsp: remove source.Cache 2020-08-05 22:08:24 +00:00
completion_statements.go internal/lsp: remove source.Cache 2020-08-05 22:08:24 +00:00
completion.go internal/lsp/source: improve unnamed type completion 2020-08-12 23:05:10 +00:00
deep_completion_test.go internal/lsp/source: fix bug in deep completion score tracking 2020-08-08 16:17:06 +00:00
deep_completion.go internal/lsp/source: fix bug in deep completion score tracking 2020-08-08 16:17:06 +00:00
diagnostics.go internal/lsp: separate LSP files from FS files 2020-08-03 22:16:06 +00:00
extract.go internal/lsp: support function calls in extract variable 2020-08-10 22:41:34 +00:00
folding_range.go internal/lsp: remove source.Cache 2020-08-05 22:08:24 +00:00
format_test.go internal/lsp: handle bad formatting with CRLF line endings 2020-07-28 16:05:17 +00:00
format.go internal/lsp: remove source.Cache 2020-08-05 22:08:24 +00:00
gc_annotations.go internal/lsp: in gc_details change command to use a temporary file. 2020-08-11 15:37:30 +00:00
highlight.go internal/lsp: remove source.Cache 2020-08-05 22:08:24 +00:00
hover.go internal/lsp: remove source.Cache 2020-08-05 22:08:24 +00:00
identifier_test.go internal/lsp/source: add a unit test for searchForEnclosing 2020-07-28 18:51:24 +00:00
identifier.go internal/lsp: remove source.Cache 2020-08-05 22:08:24 +00:00
implementation.go internal/lsp: remove source.Cache 2020-08-05 22:08:24 +00:00
options.go internal/lsp: add a configuration to limit workspace scope to root URI 2020-08-11 01:57:04 +00:00
references.go internal/lsp: remove source.Cache 2020-08-05 22:08:24 +00:00
rename_check.go internal/lsp: add changeMethods logic to rename check 2020-07-13 19:50:33 +00:00
rename.go internal/lsp: remove source.Cache 2020-08-05 22:08:24 +00:00
signature_help.go internal/lsp: remove source.Cache 2020-08-05 22:08:24 +00:00
source_test.go internal/lsp: fix a few small staticcheck warnings 2020-08-11 03:20:01 +00:00
symbols.go internal/lsp: remove source.Cache 2020-08-05 22:08:24 +00:00
types_format.go internal/lsp: remove source.Cache 2020-08-05 22:08:24 +00:00
util.go internal/lsp: remove source.Cache 2020-08-05 22:08:24 +00:00
view.go internal/lsp: extend the mod handle functions to handle multiple files 2020-08-12 18:23:14 +00:00
workspace_symbol.go internal/memoize: switch from GC-driven to explicit deletion 2020-08-10 19:02:17 +00:00