mirror of
https://github.com/golang/go
synced 2024-11-18 18:24:48 -07:00
a0a13e073c
Tweak the goimports tests to be more module-compatible. This should be the last big change to the tests; they all pass with the new implementation. The primary change is to avoid using packages not provided by the test's modules. Other modules will be downloaded at test time, which is nonhermetic and quite slow. Other miscellanea: - The appengine grouping tests have to be split out so they can be GOPATH-only, because modules have to have dots in their names. - The tests for .goimportsignore and node_modules are GOPATH-only because we decided not to include those behaviors in go/packages in module mode. - Some vendoring tests are GOPATH-only because vendoring is not a thing in module mode. - TestFindImportInLocalGoFiles changes content, because the existing test was incorrect: bogus.net/bytes was a viable candidate even though it isn't on disk. I'm not sure why it wasn't flaky. Change-Id: I35a3aac92d3fb7f70a1a8f027f0b423282420a4d Reviewed-on: https://go-review.googlesource.com/c/145138 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> |
||
|---|---|---|
| .. | ||
| fix_test.go | ||
| fix.go | ||
| imports.go | ||
| mkindex.go | ||
| mkstdlib.go | ||
| sortimports.go | ||
| zstdlib.go | ||