mirror of
https://github.com/golang/go
synced 2024-10-02 06:18:32 -06:00
c34add780b
profileBuilder.locForPC returns 0 to mean "no location" because 0 is an invalid location index. However, the code to build count profiles doesn't check the result of locForPC, so this 0 location index ends up in the profile's location list. This, in turn, causes problems later when we decode the profile because it puts a nil *Location in the sample's location slice, which can later lead to a nil pointer panic. Fix this by making printCountProfile correctly discard the result of locForPC if it returns 0. This makes this call match the other two calls of locForPC. Updates #15156. Change-Id: I4492b3652b513448bc56f4cfece4e37da5e42f94 Reviewed-on: https://go-review.googlesource.com/43630 Reviewed-by: Michael Matloob <matloob@golang.org> Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> |
||
|---|---|---|
| .. | ||
| internal/profile | ||
| testdata | ||
| elf.go | ||
| label_test.go | ||
| label.go | ||
| map.go | ||
| mprof_test.go | ||
| pprof_test.go | ||
| pprof.go | ||
| proto_test.go | ||
| proto.go | ||
| protobuf.go | ||
| protomem_test.go | ||
| protomem.go | ||
| runtime_test.go | ||
| runtime.go | ||