1
0
mirror of https://github.com/golang/go synced 2024-11-18 16:14:46 -07:00
go/internal/lsp
Rob Findley c1c69b635f internal/lsp: clean up on Shutdown even if not initialized
Previously it was an error to call shutdown while the server was not yet
initialized. This can result in session leak for very short-lived
sessions.

Instead, allow shutdown to proceed and simply log the error. On the
other hand, for consistency make it an error to call initialized without
first calling initialize.

Updates golang/go#34111

Change-Id: I0330d81323ddda6beec0f6ed9eb065f8b717dea0
Reviewed-on: https://go-review.googlesource.com/c/tools/+/222671
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-03-12 19:43:25 +00:00
..
browser internal/lsp: add version and bug commands 2019-05-11 04:16:02 +00:00
cache internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
cmd internal/lsp/lsprpc: expose configuration for auto-started daemon 2020-03-12 19:43:16 +00:00
debug internal/telemetry: convert key from string to struct 2020-03-12 04:17:52 +00:00
diff internal/span,lsp: disambiguate URIs, DocumentURIs, and paths 2020-02-14 22:51:03 +00:00
fake internal/lsp/regtest: implement formatting and organizeImports 2020-03-02 19:16:53 +00:00
fuzzy internal/lsp: make golint happy 2019-12-23 18:17:04 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/lsp/lsprpc: expose configuration for auto-started daemon 2020-03-12 19:43:16 +00:00
mod internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
protocol internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
regtest internal/lsp/lsprpc: expose configuration for auto-started daemon 2020-03-12 19:43:16 +00:00
snippet all: fix broken links to LSP specification 2019-10-02 18:32:53 +00:00
source internal/lsp/source: offer loop keyword completions in range stmt 2020-03-12 04:57:24 +00:00
telemetry internal/telemetry: convert key from string to struct 2020-03-12 04:17:52 +00:00
testdata internal/lsp/source: offer loop keyword completions in range stmt 2020-03-12 04:57:24 +00:00
tests internal/lsp/tests: fix WorkspaceSymbols tests 2020-03-11 18:46:36 +00:00
code_action.go internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
command.go internal/lsp: add an upgrade all dependencies codelens 2020-03-02 21:30:18 +00:00
completion_test.go internal/span,lsp: disambiguate URIs, DocumentURIs, and paths 2020-02-14 22:51:03 +00:00
completion.go internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
definition.go internal/lsp/source: return location(s) for imported packages 2020-03-09 16:25:02 +00:00
diagnostics.go internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
folding_range.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
format.go internal/lsp: support textDocument/formatting for .mod extension 2020-03-06 13:51:27 +00:00
general.go internal/lsp: clean up on Shutdown even if not initialized 2020-03-12 19:43:25 +00:00
highlight.go internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
hover.go internal/lsp: support textDocument/hover for .mod extension 2020-02-26 15:59:49 +00:00
implementation.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
link.go internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
lsp_test.go internal/lsp: support when hierarchicalDocumentSymbolSupport is false 2020-03-06 18:17:37 +00:00
references.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
rename.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
reset_golden.sh internal/lsp: fix regeneration of golden files 2019-09-25 13:16:59 +00:00
server_gen.go internal/lsp: support when hierarchicalDocumentSymbolSupport is false 2020-03-06 18:17:37 +00:00
server.go internal/lsp: clean up on Shutdown even if not initialized 2020-03-12 19:43:25 +00:00
signature_help.go internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
symbols.go internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
text_synchronization.go internal/lsp: clear diagnostics for deleted files 2020-02-19 20:26:41 +00:00
workspace_symbol.go internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
workspace.go internal/lsp: generate boilerplate stubs for type Server 2020-01-24 14:41:51 +00:00