1
0
mirror of https://github.com/golang/go synced 2024-11-07 10:46:18 -07:00
go/src
Austin Clements c19759aa48 runtime: eliminate externalthreadhandler
This function is no longer used.

Eliminating this actually fixes several problems:

- It made assumptions about what registers memclrNoHeapPointers would
  preserve. Besides being an abstraction violation and lurking
  maintenance issue, this actively became a problem for regabi because
  the call to memclrNoHeapPointers now happens through an ABI wrapper,
  which is generated by the compiler and hence we can't easily control
  what registers it clobbers.

- The amd64 implementation (at least), does not interact with the host
  ABI correctly. Notably, it doesn't save many of the registers that
  are callee-save in the host ABI but caller-save in the Go ABI.

- It interacts strangely with the NOSPLIT checker because it allocates
  an entire M and G on its stack. It worked around this on arm64, and
  happened to do things the NOSPLIT checker couldn't track on 386 and
  amd64, and happened to be *4 bytes* below the limit on arm (so any
  addition to the m or g structs would cause a NOSPLIT failure). See
  CL 309031 for a more complete explanation.

Fixes #45530.
Updates #40724.

Change-Id: Ic70d4d7e1c17f1d796575b3377b8529449e93576
Reviewed-on: https://go-review.googlesource.com/c/go/+/309634
Trust: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
2021-04-13 21:13:12 +00:00
..
archive archive/tar: replace os.MkdirTemp with T.TempDir 2021-04-13 21:06:12 +00:00
bufio
builtin
bytes
cmd runtime: eliminate externalthreadhandler 2021-04-13 21:13:12 +00:00
compress
container
context all: fix spellings 2021-04-10 01:46:41 +00:00
crypto all: fix spellings 2021-04-10 01:46:41 +00:00
database/sql all: fix spellings 2021-04-10 01:46:41 +00:00
debug all: simplify the spelling of Linux 2021-04-13 13:56:21 +00:00
embed embed, testing/fstest: small optimization for ReadDir 2021-04-07 09:59:58 +00:00
encoding
errors
expvar
flag
fmt
go internal/goexperiment: consolidate experiment-enabled constants 2021-04-08 02:17:18 +00:00
hash
html
image
index/suffixarray
internal internal/execabs: replace ioutil.WriteFile with os.WriteFile 2021-04-12 21:57:23 +00:00
io
log
math
mime mime: in globs2 file only keep first time extension is seen 2021-04-13 18:08:06 +00:00
net net: never probe IPv4 map support on DragonFly BSD, OpenBSD 2021-04-12 21:26:59 +00:00
os all: simplify the spelling of Linux 2021-04-13 13:56:21 +00:00
path path/filepath: replace os.MkdirTemp with T.TempDir 2021-04-10 08:13:32 +00:00
plugin
reflect reflect: panic on New of go:notinheap type 2021-04-09 23:54:31 +00:00
regexp
runtime runtime: eliminate externalthreadhandler 2021-04-13 21:13:12 +00:00
sort
strconv
strings
sync sync: update misleading comment in map.go about entry type 2021-04-08 14:08:29 +00:00
syscall syscall: replace os.MkdirTemp with T.TempDir 2021-04-07 23:00:58 +00:00
testdata
testing embed, testing/fstest: small optimization for ReadDir 2021-04-07 09:59:58 +00:00
text text/template: replace os.MkdirTemp with T.TempDir 2021-04-12 21:58:25 +00:00
time time: properly quote strings containing quotes and backslashes 2021-04-06 19:18:47 +00:00
unicode
unsafe
vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod
go.sum
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.