1
0
mirror of https://github.com/golang/go synced 2024-11-17 19:34:50 -07:00
go/misc/cgo/testshared
Bryan C. Mills f71f3d1b86 misc/cgo/testshared: run tests only in GOPATH mode
-buildmode=shared installs shared libraries into GOROOT
and expects to reuse them across builds.
Builds in module mode, however, each have their own set of
dependencies (determined by the module's requirements), so in general
cannot share dependencies with a single GOROOT.

Ideally in the long term we would like to eliminate -buildmode=shared
entirely (see #47788), but first we need a replacement for the subset
of use-cases where it still works today.

In the meantime, we should run these tests only in GOPATH mode.
Non-main packages in module mode should not be installed to
GOPATH/pkg, but due to #37015 they were installed there anyway,
and this test heavily relies on installing non-main packages.

For #37015.

Change-Id: I7c5d90b4075d6f33e3505d6a8f12752309ae5c03
Reviewed-on: https://go-review.googlesource.com/c/go/+/417194
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
2022-07-13 20:43:22 +00:00
..
testdata Revert "cmd/go: remove support for -buildmode=shared" 2021-10-29 17:32:24 +00:00
overlaydir_test.go Revert "cmd/go: remove support for -buildmode=shared" 2021-10-29 17:32:24 +00:00
shared_test.go misc/cgo/testshared: run tests only in GOPATH mode 2022-07-13 20:43:22 +00:00