1
0
mirror of https://github.com/golang/go synced 2024-11-26 11:38:01 -07:00
go/src
David Chase c08b01ecb4 cmd/compile: fix panic-okay-to-inline change; adjust tests
This line of the inlining tuning experiment
https://go-review.googlesource.com/c/go/+/109918/1/src/cmd/compile/internal/gc/inl.go#347
was incorrectly rewritten in a later patch to use the call
cost, not the panic cost, and thus the inlining of panic
didn't occur when it should.  I discovered this when I
realized that tests should have failed, but didn't.

Fix is to make the correct change, and also to modify the
tests that this causes to fail.  One test now asserts the
new normal, the other calls "ppanic" instead which is
designed to behave like panic but not be inlined.

Change-Id: I423bb7f08bd66a70d999826dd9b87027abf34cdf
Reviewed-on: https://go-review.googlesource.com/116656
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
2018-06-06 20:35:23 +00:00
..
archive all: update comment URLs from HTTP to HTTPS, where possible 2018-06-01 21:52:00 +00:00
bufio
builtin
bytes bytes: re-slice buffer to its previous length after call to grow() 2018-05-29 19:46:33 +00:00
cmd cmd/compile: fix panic-okay-to-inline change; adjust tests 2018-06-06 20:35:23 +00:00
compress all: update comment URLs from HTTP to HTTPS, where possible 2018-06-01 21:52:00 +00:00
container
context context: add benchmarks for context cancellation 2018-05-29 21:57:30 +00:00
crypto crypto/x509: use SecItemExport instead of deprecated SecKeychainItemExport 2018-06-06 17:59:08 +00:00
database/sql database/sql: update doc related to per-connection state 2018-06-06 18:18:20 +00:00
debug all: regenerate stringer files 2018-05-29 20:35:41 +00:00
encoding all: update comment URLs from HTTP to HTTPS, where possible 2018-06-01 21:52:00 +00:00
errors
expvar
flag
fmt
go go/types: add missing test case for https://golang.org/cl/116735 2018-06-06 19:46:38 +00:00
hash all: update comment URLs from HTTP to HTTPS, where possible 2018-06-01 21:52:00 +00:00
html all: update comment URLs from HTTP to HTTPS, where possible 2018-06-01 21:52:00 +00:00
image all: update comment URLs from HTTP to HTTPS, where possible 2018-06-01 21:52:00 +00:00
index/suffixarray index/suffixarray: fix a typo mistake in comments 2018-05-29 12:16:51 +00:00
internal net: add js/wasm architecture 2018-06-04 16:01:50 +00:00
io
log
math all: update comment URLs from HTTP to HTTPS, where possible 2018-06-01 21:52:00 +00:00
mime all: update comment URLs from HTTP to HTTPS, where possible 2018-06-01 21:52:00 +00:00
net net/http: remove an allocation in ServeMux 2018-06-06 01:47:31 +00:00
os os: check setStickyBit error in mkdir 2018-06-05 14:53:18 +00:00
path os: add js/wasm architecture 2018-06-01 05:18:38 +00:00
plugin
reflect reflect: add StructOf test case that gccgo used to fail 2018-06-06 14:08:42 +00:00
regexp all: update comment URLs from HTTP to HTTPS, where possible 2018-06-01 21:52:00 +00:00
runtime cmd/compile: fix panic-okay-to-inline change; adjust tests 2018-06-06 20:35:23 +00:00
sort all: update comment URLs from HTTP to HTTPS, where possible 2018-06-01 21:52:00 +00:00
strconv strconv: check for empty string in UnquoteChar 2018-06-04 22:06:42 +00:00
strings all: update comment URLs from HTTP to HTTPS, where possible 2018-06-01 21:52:00 +00:00
sync
syscall net: add js/wasm architecture 2018-06-04 16:01:50 +00:00
testing Revert "testing: only compute b.N once when passed -count > 1" 2018-05-31 14:22:44 +00:00
text text/tabwriter: fix BenchmarkPyramid and BenchmarkRagged again 2018-06-04 17:32:17 +00:00
time runtime: don't crash holding locks on racy timer access 2018-06-04 18:33:41 +00:00
unicode all: update comment URLs from HTTP to HTTPS, where possible 2018-06-01 21:52:00 +00:00
unsafe
vendor/golang_org/x net/http: vendor x/net/http/httpproxy, use it in net/http 2018-05-29 21:54:57 +00:00
all.bash
all.bat
all.rc
androidtest.bash
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
iostest.bash
make.bash
make.bat
Make.dist
make.rc
naclmake.bash
nacltest.bash
race.bash
race.bat
run.bash
run.bat
run.rc