mirror of
https://github.com/golang/go
synced 2024-10-01 06:08:32 -06:00
c07e1c6ef6
Improve candidate ranking when completing the variadic parameter of
function calls.
Using the example:
func foo(strs ...string) {}
- When completing foo(<>), we prefer candidates of type []string or
string (previously we only preferred []string).
- When completing foo("hi", <>), we prefer candidates of type
string (previously we preferred []string).
- When completing foo(<>), we use a snippet to add on the "..."
automatically to candidates of type []string.
I also fixed completion tests to work properly when you have multiple
notes referring to the same position. For example:
foo() //@rank(")", a, b),rank(")", a, c)
Previously the second "rank" was silently overwriting the first
because they both refer to the same ")".
Fixes golang/go#34334.
Change-Id: I4f64be44a4ccbb533fb7682738c759cbca3a93cd
Reviewed-on: https://go-review.googlesource.com/c/tools/+/205117
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
24 lines
491 B
Plaintext
24 lines
491 B
Plaintext
-- summary --
|
|
CompletionsCount = 214
|
|
CompletionSnippetCount = 43
|
|
UnimportedCompletionsCount = 3
|
|
DeepCompletionsCount = 5
|
|
FuzzyCompletionsCount = 7
|
|
RankedCompletionsCount = 16
|
|
CaseSensitiveCompletionsCount = 4
|
|
DiagnosticsCount = 22
|
|
FoldingRangesCount = 2
|
|
FormatCount = 6
|
|
ImportCount = 2
|
|
SuggestedFixCount = 1
|
|
DefinitionsCount = 38
|
|
TypeDefinitionsCount = 2
|
|
HighlightsCount = 2
|
|
ReferencesCount = 6
|
|
RenamesCount = 20
|
|
PrepareRenamesCount = 8
|
|
SymbolsCount = 1
|
|
SignaturesCount = 21
|
|
LinksCount = 4
|
|
|