mirror of
https://github.com/golang/go
synced 2024-10-01 04:08:32 -06:00
c07e1c6ef6
Improve candidate ranking when completing the variadic parameter of
function calls.
Using the example:
func foo(strs ...string) {}
- When completing foo(<>), we prefer candidates of type []string or
string (previously we only preferred []string).
- When completing foo("hi", <>), we prefer candidates of type
string (previously we preferred []string).
- When completing foo(<>), we use a snippet to add on the "..."
automatically to candidates of type []string.
I also fixed completion tests to work properly when you have multiple
notes referring to the same position. For example:
foo() //@rank(")", a, b),rank(")", a, c)
Previously the second "rank" was silently overwriting the first
because they both refer to the same ")".
Fixes golang/go#34334.
Change-Id: I4f64be44a4ccbb533fb7682738c759cbca3a93cd
Reviewed-on: https://go-review.googlesource.com/c/tools/+/205117
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
|
||
|---|---|---|
| .. | ||
| comment_test.go | ||
| comment.go | ||
| completion_format.go | ||
| completion_keywords.go | ||
| completion_labels.go | ||
| completion_literal.go | ||
| completion_snippet.go | ||
| completion.go | ||
| deep_completion.go | ||
| diagnostics.go | ||
| errors.go | ||
| folding_range.go | ||
| format.go | ||
| highlight.go | ||
| hover.go | ||
| identifier.go | ||
| implementation.go | ||
| imports_test.go | ||
| imports.go | ||
| options.go | ||
| references.go | ||
| rename_check.go | ||
| rename.go | ||
| signature_help.go | ||
| source_test.go | ||
| suggested_fix.go | ||
| symbols.go | ||
| tidy.go | ||
| util.go | ||
| view.go | ||