Bryan C. Mills 39a9cb4b5d misc/cgo/testplugin: avoid writing to GOROOT ... One of the 'go build' commands executed by this test passed the '-i' flag, which caused the 'go' command to attempt to install transitive standard-library dependencies to GOROOT/pkg/$GOOS_$GOARCH_dynlink. That failed if GOROOT/pkg was not writable (for example, if GOROOT was owned by the root user, but the user running the test was not root). As far as I can tell the '-i' flag is not necessary in this test. Prior to the introduction of the build cache it may have been an optimization, but now that the build cache is required the '-i' flag only adds extra work. Updates #30316 Change-Id: Ib60080a008c1941aa92b5bdd5a194d89fd6202aa Reviewed-on: https://go-review.googlesource.com/c/go/+/208120 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>		2019-11-20 22:38:34 +00:00
..
altpath/testdata
testdata	misc/cgo: gofmt testdata files	2019-03-22 07:21:24 +00:00
overlaydir_test.go	misc: ensure that test overlay directories are writable	2019-11-11 17:59:46 +00:00
plugin_test.go	misc/cgo/testplugin: avoid writing to GOROOT	2019-11-20 22:38:34 +00:00