1
0
mirror of https://github.com/golang/go synced 2024-11-19 23:14:47 -07:00
go/src/fmt
Rob Pike 049b89dc6f fmt: treat reflect.Value specially - as the value it holds
When a reflect.Value is passed to Printf (etc.), fmt called the
String method, which does not disclose its contents. To get the
contents, one could call Value.Interface(), but that is illegal
if the Value is not exported or otherwise forbidden.

This CL improves the situation with a trivial change to the
fmt package: when we see a reflect.Value as an argument,
we treat it exactly as we treat a reflect.Value we make inside
the package. This means that we always print the
contents of the Value as if _that_ was the argument to Printf.

This is arguably a breaking change but I think it is a genuine
improvement and no greater a break than many other tweaks
we have made to formatted output from this package.

Fixes #8965.

Change-Id: Ifc2a4ce3c1134ad5160e101d2196c22f1542faab
Reviewed-on: https://go-review.googlesource.com/8731
Reviewed-by: roger peppe <rogpeppe@gmail.com>
Reviewed-by: Russ Cox <rsc@golang.org>
2015-04-15 15:59:39 +00:00
..
doc.go fmt: treat reflect.Value specially - as the value it holds 2015-04-15 15:59:39 +00:00
export_test.go
fmt_test.go fmt: treat reflect.Value specially - as the value it holds 2015-04-15 15:59:39 +00:00
format.go fmt: empty byte slices should print nothing in hex 2015-04-13 20:50:13 +00:00
print.go fmt: treat reflect.Value specially - as the value it holds 2015-04-15 15:59:39 +00:00
scan_test.go fmt: fix bug in scanning of hex strings 2014-12-22 04:08:32 +00:00
scan.go fmt: fix bug in scanning of hex strings 2014-12-22 04:08:32 +00:00
stringer_test.go