mirror of
https://github.com/golang/go
synced 2024-11-15 03:50:33 -07:00
321a220d50
On AIX when external linking, for some symbols we need to add dummy references to prevent the external linker from discarding them. Currently we add the reference unconditionally. But if the symbol doesn't exist, the linking fails in a later stage for generating external relocation of a nonexistent symbol. The symbols are special symbols that almost always exist, except that go:buildid may not exist if the linker is invoked without the -buildid flag. The go command invokes the linker with the flag, so this can only happen with manual linker invocation. Specifically, test/run.go does this in some cases. Fix this by checking the symbol existence before adding the reference. Re-enable tests on AIX. Perhaps the linker should always emit a dummy buildid even if the flag is not set... Fixes #54814. Change-Id: I43d81587151595309e189e38960cbda9a1c5ca32 Reviewed-on: https://go-review.googlesource.com/c/go/+/427620 Run-TryBot: Cherry Mui <cherryyz@google.com> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Than McIntosh <thanm@google.com>
32 lines
432 B
Go
32 lines
432 B
Go
// run
|
|
|
|
// Copyright 2020 The Go Authors. All rights reserved. Use of this
|
|
// source code is governed by a BSD-style license that can be found in
|
|
// the LICENSE file.
|
|
|
|
//go:build cgo
|
|
|
|
package main
|
|
|
|
import "runtime/cgo"
|
|
|
|
type NIH struct {
|
|
_ cgo.Incomplete
|
|
}
|
|
|
|
type T struct {
|
|
x *NIH
|
|
p *int
|
|
}
|
|
|
|
var y NIH
|
|
var z int
|
|
|
|
func main() {
|
|
a := []T{{&y, &z}}
|
|
a = append(a, T{&y, &z})
|
|
if a[1].x == nil {
|
|
panic("pointer not written")
|
|
}
|
|
}
|