mirror of
https://github.com/golang/go
synced 2024-11-23 15:30:05 -07:00
93453233bd
Like other builtin functions, unsafe.Add's len operand is allowed to be variable sized. However, unlike other builtins, it doesn't get lowered to a runtime function call, so we never end up coercing it to a specific type. As a result, we could end up constructing an OpAddPtr value but with a less-than-ptr-sized addend operand. This CL fixes this by always coercing the second operand to uintptr during SSA construction. Theoretically, we could do this during walk instead, but the frontend doesn't allow converting negative constants to uintptr. Fixes #48536. Change-Id: Ib0619ea79df58b256b250fec967a6d3c8afea631 Reviewed-on: https://go-review.googlesource.com/c/go/+/351592 Trust: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
30 lines
500 B
Go
30 lines
500 B
Go
// run
|
|
|
|
// Copyright 2021 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
import "unsafe"
|
|
|
|
var i = 257
|
|
|
|
func main() {
|
|
var buf [10]byte
|
|
p0 := unsafe.Pointer(&buf[0])
|
|
p1 := unsafe.Pointer(&buf[1])
|
|
|
|
if p := unsafe.Add(p0, uint8(i)); p != p1 {
|
|
println("FAIL:", p, "!=", p1)
|
|
}
|
|
|
|
var x uint8
|
|
if i != 0 {
|
|
x = 1
|
|
}
|
|
if p := unsafe.Add(p0, x); p != p1 {
|
|
println("FAIL:", p, "!=", p1)
|
|
}
|
|
}
|