1
0
mirror of https://github.com/golang/go synced 2024-11-26 00:57:56 -07:00
go/src
Alan Donovan bf91eb3a8b std: fix calls to Printf(s) with non-constant s
In all cases the intent was not to interpret s as a format string.
In one case (go/types), this was a latent bug in production.
(These were uncovered by a new check in vet's printf analyzer.)

Updates #60529

Change-Id: I3e17af7e589be9aec1580783a1b1011c52ec494b
Reviewed-on: https://go-review.googlesource.com/c/go/+/587855
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Russ Cox <rsc@golang.org>
2024-05-23 18:42:28 +00:00
..
archive all: change from sort functions to slices functions where feasible 2024-05-23 01:00:11 +00:00
arena
bufio
builtin
bytes all: change from sort functions to slices functions where feasible 2024-05-23 01:00:11 +00:00
cmd std: fix calls to Printf(s) with non-constant s 2024-05-23 18:42:28 +00:00
cmp
compress
container
context
crypto std: fix calls to Printf(s) with non-constant s 2024-05-23 18:42:28 +00:00
database/sql std: fix calls to Printf(s) with non-constant s 2024-05-23 18:42:28 +00:00
debug
embed embed: simplify the code 2024-05-20 19:42:51 +00:00
encoding std: fix calls to Printf(s) with non-constant s 2024-05-23 18:42:28 +00:00
errors
expvar
flag flag: replace sort.Slice with slices.SortFunc 2024-05-07 18:38:24 +00:00
fmt all: change from sort functions to slices functions where feasible 2024-05-23 01:00:11 +00:00
go std: fix calls to Printf(s) with non-constant s 2024-05-23 18:42:28 +00:00
hash hash: use more internal/byteorder functions to simplify the code 2024-05-18 22:36:41 +00:00
html html: update jstmpllitinterp doc 2024-05-22 18:04:29 +00:00
image image/gif: use internal/byteorder 2024-05-13 21:38:09 +00:00
index/suffixarray all: change from sort functions to slices functions where feasible 2024-05-23 01:00:11 +00:00
internal std: fix calls to Printf(s) with non-constant s 2024-05-23 18:42:28 +00:00
io all: change from sort functions to slices functions where feasible 2024-05-23 01:00:11 +00:00
iter iter: detect and reject double next and double yield in Pull, Pull2 2024-05-08 18:03:22 +00:00
log log/slog: handle times with undefined UnixNanos 2024-05-16 16:12:08 +00:00
maps maps: slightly improve iter tests 2024-05-23 03:44:19 +00:00
math std: fix calls to Printf(s) with non-constant s 2024-05-23 18:42:28 +00:00
mime all: change from sort functions to slices functions where feasible 2024-05-23 01:00:11 +00:00
net std: fix calls to Printf(s) with non-constant s 2024-05-23 18:42:28 +00:00
os all: change from sort functions to slices functions where feasible 2024-05-23 01:00:11 +00:00
path all: change from sort functions to slices functions where feasible 2024-05-23 01:00:11 +00:00
plugin
reflect all: document legacy //go:linkname for modules with ≥2,000 dependents 2024-05-23 01:16:47 +00:00
regexp
runtime std: fix calls to Printf(s) with non-constant s 2024-05-23 18:42:28 +00:00
slices slices: fix punctuation in the documentation of Values 2024-05-13 21:40:32 +00:00
sort
strconv strconv: use stringslite.Clone 2024-05-05 00:24:26 +00:00
strings strings: move Clone to stringslite 2024-05-04 01:23:42 +00:00
structs cmd/compile: add structs.HostLayout 2024-05-20 21:19:39 +00:00
sync all: document legacy //go:linkname for modules with ≥500 dependents 2024-05-23 01:16:53 +00:00
syscall all: document legacy //go:linkname for modules with ≥1,000 dependents 2024-05-23 01:16:50 +00:00
testdata
testing cmd/go,testdeps: move import of internal/coverage/cfile to testmain 2024-05-23 14:01:23 +00:00
text fmt, internal/fmtsort: refactor SortedMap to use slice of structs for map sorting 2024-05-13 21:22:43 +00:00
time time: add a few more benchmarks 2024-05-23 03:13:47 +00:00
unicode
unique internal/concurrent: make HashTrieMap iteration more idiomatic 2024-05-22 16:01:55 +00:00
unsafe unsafe: document the behavior of Sizeof on an interface 2024-05-21 19:45:20 +00:00
vendor cmd: vendor golang.org/x/sys@v0.20.0 2024-05-08 16:12:58 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod cmd: vendor golang.org/x/sys@v0.20.0 2024-05-08 16:12:58 +00:00
go.sum cmd: vendor golang.org/x/sys@v0.20.0 2024-05-08 16:12:58 +00:00
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash run.bash: rm bumping open files soft limit 2024-05-15 15:02:23 +00:00
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto', and if you use a go.work file, set GOWORK=off.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src  # or src/cmd
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.