1
0
mirror of https://github.com/golang/go synced 2024-11-18 18:44:42 -07:00
go/internal/lsp
Rohan Challa bdebc07e97 internal/lsp: fix highlighting of inexact matches when highlighting from the right
There is an issue when highlighting a single character identifier if the cursor is on the right of it. This problem
is a result of an assumption made in astutil.PathEnclosingInterval relating to the arguments passed in. Specifically,
if start==end, the 1-char interval following start is used instead. As a result, we might not get an exact match
so we should check the 1-char interval to the left of the passed in position to see if that is an exact match.

Updates golang/go#34496

Change-Id: If689fdf695df6ec1bc1935088e50d3de055bd5db
Reviewed-on: https://go-review.googlesource.com/c/tools/+/212137
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rohan Challa <rohan@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-12-19 19:05:06 +00:00
..
browser internal/lsp: add version and bug commands 2019-05-11 04:16:02 +00:00
cache internal/lsp: add gopls setting to disable use of -modfile flag behavior 2019-12-19 18:11:24 +00:00
cmd internal/lsp: change CompletionItem.{Command,TextEdit} to pointers 2019-12-16 22:14:42 +00:00
debug internal/lsp/debug: print the debug port 2019-12-18 04:04:34 +00:00
diff internal/lsp: fix unified diffs of edits at the end of a file 2019-10-11 16:38:14 +00:00
fuzzy internal/lsp: fix fuzzy matcher inconsistency 2019-10-22 21:05:28 +00:00
protocol internal/lps/protocol: bring code.ts up to date with latest changes. 2019-12-19 18:45:41 +00:00
snippet all: fix broken links to LSP specification 2019-10-02 18:32:53 +00:00
source internal/lsp: fix highlighting of inexact matches when highlighting from the right 2019-12-19 19:05:06 +00:00
telemetry internal/lsp: call load in (*session).NewView 2019-11-07 23:34:59 +00:00
testdata internal/lsp: fix highlighting of inexact matches when highlighting from the right 2019-12-19 19:05:06 +00:00
tests internal/lsp: change CompletionItem.{Command,TextEdit} to pointers 2019-12-16 22:14:42 +00:00
code_action.go internal/lsp: rename CheckPackageHandle to PackageHandle 2019-12-02 18:29:46 +00:00
command.go internal/lsp: fix panic in bestView 2019-11-16 21:44:31 +00:00
completion_test.go internal/lsp: offer basic type conversion candidates 2019-12-12 22:41:01 +00:00
completion.go internal/lsp: change CompletionItem.{Command,TextEdit} to pointers 2019-12-16 22:14:42 +00:00
definition.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
diagnostics.go internal/lsp: don't resend diagnostics if they are unchanged 2019-12-12 04:27:51 +00:00
folding_range.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
format.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
general.go internal/lsp: return snapshot when creating a view 2019-12-05 13:33:17 +00:00
highlight.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
hover.go internal/lsp: improve link in documentation on hover 2019-12-12 22:39:21 +00:00
implementation.go internal/lsp: fix find-implementation for promoted methods 2019-12-16 21:36:29 +00:00
link.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
lsp_test.go internal/lsp: return snapshots from text modifications 2019-12-18 22:53:40 +00:00
references.go internal/lsp: fix find-references to search from all package variants 2019-12-11 23:36:49 +00:00
rename.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
reset_golden.sh internal/lsp: fix regeneration of golden files 2019-09-25 13:16:59 +00:00
server.go internal/lsp: don't resend diagnostics if they are unchanged 2019-12-12 04:27:51 +00:00
signature_help.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
symbols.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
text_synchronization.go internal/lsp: return snapshots from text modifications 2019-12-18 22:53:40 +00:00
watched_files.go internal/lsp: move DidModifyFile into internal/lsp/cache 2019-12-12 03:49:59 +00:00
workspace.go internal/lsp: return snapshot when creating a view 2019-12-05 13:33:17 +00:00