1
0
mirror of https://github.com/golang/go synced 2024-11-16 19:34:48 -07:00
go/src
Li bdc5533f39 runtime: pad work.full and pad.empty to avoid false sharing
With the Garbage collector (GC), we observed a false-sharing between
work.full and work.empty. (referenced most from runtime.gcDrain and
runtime.getempty)

This false-sharing becomes worse and impact performance on multi core
system. On Intel Xeon 8480+ and default GC setting(GC=100), we can
observed top HITM>4% (by perf c2c)caused by it.

After resolveed this false-sharing issue, we can get performance 8%~9.7%
improved. Verify workloads:

DeathStarBench/hotelReservation: 9.7% of RPS improved
https://github.com/delimitrou/DeathStarBench/tree/master/hotelReservation

gRPC-go/benchmark: 8% of RPS improved
https://github.com/grpc/grpc-go/tree/master/benchmark

gRPC-go/benchmark 9 iterations' data with master branch:
	master	        w/ fs opt.
	208862.4	246390.9
	221680.0	266019.3
	223886.9	248789.7
	212169.3	257837.8
	219922.4	234331.8
	197401.7	261627.7
	214562.4	255429.7
	214328.5	237087.8
	229443.2	230591.3

max	229443.2	266019.3	116%
med	214562.4	248789.7	116%
avg	215806.3	248678.5	115%

Change-Id: Ib386de021cd2dbb802a107f487556d848ba9212d
Reviewed-on: https://go-review.googlesource.com/c/go/+/496915
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Run-TryBot: Keith Randall <khr@golang.org>
2023-05-24 01:03:09 +00:00
..
archive
arena
bufio
builtin
bytes
cmd cmd/go: add mod edit -toolchain and work edit -toolchain 2023-05-24 00:49:56 +00:00
cmp
compress
container
context
crypto crypto/rsa: make DecryptPKCS1v15SessionKey warning more dire 2023-05-23 17:30:20 +00:00
database/sql
debug debug/elf: define R_PPC64_REL24_P9NOTOC 2023-05-23 21:46:00 +00:00
embed
encoding encoding: document when marshaling methods can be added 2023-05-23 19:43:37 +00:00
errors
expvar
flag
fmt fmt,math/big,net/url: fixes to old Benchmarks 2023-05-23 20:25:13 +00:00
go cmd/compile: report an error URL with error messages 2023-05-24 00:18:17 +00:00
hash
html
image
index/suffixarray
internal go/types, types2: enable interface inference 2023-05-23 22:13:57 +00:00
io
log log/slog: JSONHandler doesn't use special source format 2023-05-23 20:22:03 +00:00
maps
math fmt,math/big,net/url: fixes to old Benchmarks 2023-05-23 20:25:13 +00:00
mime
net fmt,math/big,net/url: fixes to old Benchmarks 2023-05-23 20:25:13 +00:00
os os: make TestProgWideChdir detect more possible failure cases 2023-05-24 00:38:42 +00:00
path
plugin
reflect
regexp
runtime runtime: pad work.full and pad.empty to avoid false sharing 2023-05-24 01:03:09 +00:00
slices slices: add sorting and comparison functions 2023-05-23 23:33:29 +00:00
sort slices: add sorting and comparison functions 2023-05-23 23:33:29 +00:00
strconv
strings
sync syscall: avoid serializing forks on ForkLock 2023-05-23 17:25:09 +00:00
syscall syscall: avoid serializing forks on ForkLock 2023-05-23 17:25:09 +00:00
testdata
testing cmd/go,testing: re-implement testing.Coverage 2023-05-23 11:37:31 +00:00
text
time
unicode
unsafe
vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod
go.sum
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto'.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.