mirror of
https://github.com/golang/go
synced 2024-10-01 07:38:32 -06:00
ad473c03aa
When we are processing a go.mod file, we are calling go/packages.load when we should not be. It will always return 0 packages since it is not a .go file. This CL adds branching inside each internal/lsp protocol function and also adds a check in snapshot.PackageHandles for the file type and returns an error. This will prevent `go list` from running on go.mod files for now. Updates golang/go#31999 Change-Id: Ic6d0e9b7c81e1f404342b98e10b9c5387adde2ee Reviewed-on: https://go-review.googlesource.com/c/tools/+/210757 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rohan Challa <rohan@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
62 lines
1.7 KiB
Go
62 lines
1.7 KiB
Go
// Copyright 2018 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package lsp
|
|
|
|
import (
|
|
"context"
|
|
|
|
"golang.org/x/tools/internal/lsp/protocol"
|
|
"golang.org/x/tools/internal/lsp/source"
|
|
"golang.org/x/tools/internal/span"
|
|
"golang.org/x/tools/internal/telemetry/log"
|
|
"golang.org/x/tools/internal/telemetry/tag"
|
|
)
|
|
|
|
func (s *Server) signatureHelp(ctx context.Context, params *protocol.SignatureHelpParams) (*protocol.SignatureHelp, error) {
|
|
uri := span.NewURI(params.TextDocument.URI)
|
|
view, err := s.session.ViewOf(uri)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
snapshot := view.Snapshot()
|
|
f, err := view.GetFile(ctx, uri)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if f.Kind() != source.Go {
|
|
return nil, nil
|
|
}
|
|
info, err := source.SignatureHelp(ctx, snapshot, f, params.Position)
|
|
if err != nil {
|
|
log.Print(ctx, "no signature help", tag.Of("At", params.Position), tag.Of("Failure", err))
|
|
return nil, nil
|
|
}
|
|
return toProtocolSignatureHelp(info), nil
|
|
}
|
|
|
|
func toProtocolSignatureHelp(info *source.SignatureInformation) *protocol.SignatureHelp {
|
|
return &protocol.SignatureHelp{
|
|
ActiveParameter: float64(info.ActiveParameter),
|
|
ActiveSignature: 0, // there is only ever one possible signature
|
|
Signatures: []protocol.SignatureInformation{
|
|
{
|
|
Label: info.Label,
|
|
Documentation: info.Documentation,
|
|
Parameters: toProtocolParameterInformation(info.Parameters),
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
func toProtocolParameterInformation(info []source.ParameterInformation) []protocol.ParameterInformation {
|
|
var result []protocol.ParameterInformation
|
|
for _, p := range info {
|
|
result = append(result, protocol.ParameterInformation{
|
|
Label: p.Label,
|
|
})
|
|
}
|
|
return result
|
|
}
|