bb53a5ad43
The compiler chooses the literal value export format by type not by constant.Kind. That is, a floating-point constant is always exported as a (big) float value, not a (big) rational value, even though the internal representation may be that of a rational number. (This is a possibility now that the compiler also uses the go/constant package.) Naturally, during import, a floating-point value is read as a float and represented as a (big) float in go/constant. The types2 importer (based on the go/types importer) read the floating-point number elements (mantissa, exponent) but then constructed the float go/constant value through a series of elementary operations, typically leading to a rational, but sometimes even an integer number (e.g. for math.MaxFloat64). There is no problem with that (the value is the same) but if we want to impose bitsize limits on overlarge integer values we quickly run into trouble with large floats represented as integers. This change matches the code importing float literals with the code used by the compiler. Note: At some point we may want to relax the import/export code for constant values and export them by representation rather than by type. As is, we lose accuracy since all floating-point point values, even the ones internally represented as rational numbers end up being exported as floating-point numbers. Change-Id: Ic751b2046a0fd047f751da3d35cbef0a1b5fea3e Reviewed-on: https://go-review.googlesource.com/c/go/+/288632 Trust: Robert Griesemer <gri@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| favicon.ico | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| robots.txt | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.