b7cb92ad12
The last primary usage of renameio was the WriteFile in modfetch.WriteDiskCache. Because it's not guaranteed that the fsync in WriteDiskCache will eliminate file corruption, and it slows down tests on Macs significantly, inline that last usage, removing the fsync. Also, remove the uses of renameio.Pattern. The ziphash file is no longer written to a temporary location before being copied to its final location, so that usage can just be cut. The remaining use is for the zipfile . Remove the first because the files are no longer written using the pattern anyway, so that the pattern variable has no effect. Replace it with a local pattern variable that is also passed to os.CreateTemp. Change-Id: Icf3adabf2a26c37b82afa1d07f821a46b30d69ce Reviewed-on: https://go-review.googlesource.com/c/go/+/301889 Trust: Michael Matloob <matloob@golang.org> Run-TryBot: Michael Matloob <matloob@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Jay Conrod <jayconrod@google.com> TryBot-Result: Go Bot <gobot@golang.org> |
||
---|---|---|
.github | ||
api | ||
doc | ||
lib/time | ||
misc | ||
src | ||
test | ||
.gitattributes | ||
.gitignore | ||
AUTHORS | ||
codereview.cfg | ||
CONTRIBUTING.md | ||
CONTRIBUTORS | ||
LICENSE | ||
PATENTS | ||
README.md | ||
SECURITY.md |
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://golang.org/doc/contribute.html.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.