1
0
mirror of https://github.com/golang/go synced 2024-09-28 20:24:29 -06:00
go/src
Keith Randall b730a26729 [dev.typeparams] cmd/compile: put shape types in their own package
Put shape types in the top level package called ".shape".
Name them using the serialization of the shape name, instead of
the .shapeN names.

This allows the linker to deduplicate instantiations across packages.

Not sure that this is entirely correct, as shapes in this package
may reference other packages (e.g. a field of a struct). But it seems
to work for now.

For the added test, when you look at the resulting binary (use the -k
option with run.go) it has only one instantiation of F, and 4 call sites:

$ objdump -d a.exe | grep _a\.F
 1053cb0:	e8 8b 00 00 00 	callq	139 <_a.F[.shape.*uint8]>
 1053ce9:	e8 52 00 00 00 	callq	82 <_a.F[.shape.*uint8]>
_a.F[.shape.*uint8]:
 1053d90:	e8 ab ff ff ff 	callq	-85 <_a.F[.shape.*uint8]>
 1053dc9:	e8 72 ff ff ff 	callq	-142 <_a.F[.shape.*uint8]>

Change-Id: I627f7e50210aabe4a10d0e2717d87b75ac82e99b
Reviewed-on: https://go-review.googlesource.com/c/go/+/339595
Trust: Keith Randall <khr@golang.org>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
2021-08-04 17:56:00 +00:00
..
archive
bufio
builtin
bytes
cmd [dev.typeparams] cmd/compile: put shape types in their own package 2021-08-04 17:56:00 +00:00
compress
container
context
crypto crypto/x509: update iOS bundled roots to version 55188.120.1.0.1 2021-07-26 14:24:27 +00:00
database/sql database/sql: fix deadlock test in prepare statement 2021-06-21 17:37:23 +00:00
debug debug/elf: don't apply DWARF relocations for ET_EXEC binaries 2021-06-14 22:13:47 +00:00
embed
encoding
errors
expvar
flag
fmt fmt: split package documentation into more sections 2021-06-07 15:17:48 +00:00
go [dev.typeparams] go/types: move instance.go contents into named.go (cleanup) 2021-08-04 11:07:34 +00:00
hash
html
image image/gif: fix typo in the comment (io.ReadByte -> io.ByteReader) 2021-06-30 17:58:50 +00:00
index/suffixarray
internal [dev.typeparams] all: merge master (c8f4e61) into dev.typeparams 2021-07-20 14:34:09 -07:00
io io/fs: minor corrections to Sub docs 2021-06-02 18:52:58 +00:00
log
math math/big: fix typo of comment (BytesScanner to ByteScanner) 2021-06-29 16:57:13 +00:00
mime
net net/http: correct capitalization in cancelTimeBody comment 2021-07-16 02:43:48 +00:00
os os: change example to avoid deprecated function 2021-06-30 16:44:19 +00:00
path path/filepath: deflake TestEvalSymlinksAboveRoot on darwin 2021-06-30 20:03:34 +00:00
plugin
reflect [dev.typeparams] all: merge master (798ec73) into dev.typeparams 2021-07-22 12:50:31 -07:00
regexp
runtime [dev.typeparams] runtime: handle d.link carefully when freeing a defer 2021-08-04 15:51:58 +00:00
sort
strconv strconv: document parsing of leading +/- 2021-06-09 18:16:27 +00:00
strings
sync
syscall syscall: fix TestGroupCleanupUserNamespace test failure on Fedora 2021-06-16 04:45:46 +00:00
testdata
testing testing: clarify in docs that TestMain is advanced 2021-07-15 20:39:22 +00:00
text text/scanner: use Go convention in Position doc comment 2021-07-18 21:00:03 +00:00
time runtime: don't clear timerModifiedEarliest if adjustTimers is 0 2021-07-22 19:26:40 +00:00
unicode
unsafe spec, unsafe: clarify unsafe.Slice docs 2021-07-02 19:26:52 +00:00
vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod [dev.typeparams] src,cmd: bump go.mod to 'go 1.18' 2021-07-02 23:55:07 +00:00
go.sum [dev.typeparams] src,cmd: run 'go mod tidy' 2021-07-03 17:45:01 +00:00
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.