1
0
mirror of https://github.com/golang/go synced 2024-09-30 22:48:32 -06:00
go/internal/lsp/cache
Rebecca Stambler b5fc9d354d internal/lsp: add parse errors as diagnostics even when parsing fails
When a package consists of files that only fail to parse, we fail to
associate parse errors with the package, and therefore return no
diagnostics. To address this, we need to associate the errors with the
package. This involves adding a *token.File to the parseGoData so that
error messages and positions can be properly extracted, even when there
is no associated AST.

Fixes golang/go#39763

Change-Id: I5620821b9bcbeb499c498f9061dcf487d159bed5
Reviewed-on: https://go-review.googlesource.com/c/tools/+/243579
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-07-24 17:29:32 +00:00
..
analysis.go internal/memoize: add an error return to (*handle).Get 2020-06-24 16:33:19 +00:00
cache.go internal/lsp: don't keep track of closed overlays 2020-07-16 17:49:00 +00:00
check.go internal/lsp: add parse errors as diagnostics even when parsing fails 2020-07-24 17:29:32 +00:00
error_test.go internal/lsp: refactor error handling code in type-checking 2019-10-21 18:57:46 +00:00
errors.go internal/lsp: add parse errors as diagnostics even when parsing fails 2020-07-24 17:29:32 +00:00
keys.go internal/lsp: decouple client and server debug 2020-06-11 13:49:48 +00:00
load.go internal/lsp: treat the module root as the workspace root, if available 2020-07-23 21:33:49 +00:00
mod_tidy.go internal/lsp: add errors for missing modules that don't map to an import 2020-07-24 00:18:24 +00:00
mod.go internal/lsp: treat the module root as the workspace root, if available 2020-07-23 21:33:49 +00:00
os_darwin.go internal/lsp: add a mutex around the view's options 2020-04-02 16:41:49 +00:00
os_windows.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
parse.go internal/lsp: add parse errors as diagnostics even when parsing fails 2020-07-24 17:29:32 +00:00
pkg.go internal/lsp/source: add a new symbolStyle configuration option 2020-06-26 17:13:37 +00:00
session.go internal/lsp: handle unknown revision in go.mod file 2020-07-21 21:40:18 +00:00
snapshot.go internal/lsp: treat the module root as the workspace root, if available 2020-07-23 21:33:49 +00:00
view_test.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
view.go internal/lsp: treat the module root as the workspace root, if available 2020-07-23 21:33:49 +00:00