mirror of
https://github.com/golang/go
synced 2024-11-18 02:54:47 -07:00
8e6dfe1b31
Deal with export/import of recursive generic types. This includes
typeparams which have bounds that reference the typeparam.
There are three main changes:
- Change export/import of typeparams to have an implicit "declaration"
(doDecl). We need to do a declaration of typeparams (via the
typeparam's package and unique name), because it may be referenced
within its bound during its own definition.
- We delay most of the processing of the Instantiate call until we
finish the creation of the top-most type (similar to the way we
delay CheckSize). This is because we can't do the full instantiation
properly until the base type is fully defined (with methods). The
functions delayDoInst() and resumeDoInst() delay and resume the
processing of the instantiations.
- To do the full needed type substitutions for type instantiations
during import, I had to separate out the type subster in stencil.go
and move it to subr.go in the typecheck package. The subster in
stencil.go now does node substitution and makes use of the type
subster to do type substitutions.
Notable other changes:
- In types/builtins.go, put the newly defined typeparam for a union type
(related to use of real/imag, etc.) in the current package, rather
than the builtin package, so exports/imports work properly.
- In types2, allowed NewTypeParam() to be called with a nil bound, and
allow setting the bound later. (Needed to import a typeparam whose
bound refers to the typeparam itself.)
- During import of typeparams in types2 (importer/import.go), we need
to keep an index of the typeparams by their package and unique name
(with id). Use a new map typParamIndex[] for that. Again, this is
needed to deal with typeparams whose bounds refer to the typeparam
itself.
- Added several new tests absdiffimp.go and orderedmapsimp.go. Some of
the orderemapsimp tests are commented out for now, because there are
some issues with closures inside instantiations (relating to unexported
names of closure structs).
- Renamed some typeparams in test value.go to make them all T (to make
typeparam uniqueness is working fine).
Change-Id: Ib47ed9471c19ee8e9fbb34e8506907dad3021e5a
Reviewed-on: https://go-review.googlesource.com/c/go/+/323029
Trust: Dan Scales <danscales@google.com>
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
76 lines
1.5 KiB
Go
76 lines
1.5 KiB
Go
// run -gcflags=-G=3
|
|
|
|
// Copyright 2021 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
import "fmt"
|
|
|
|
type value[T any] struct {
|
|
val T
|
|
}
|
|
|
|
func get[T any](v *value[T]) T {
|
|
return v.val
|
|
}
|
|
|
|
func set[T any](v *value[T], val T) {
|
|
v.val = val
|
|
}
|
|
|
|
func (v *value[T]) set(val T) {
|
|
v.val = val
|
|
}
|
|
|
|
func (v *value[T]) get() T {
|
|
return v.val
|
|
}
|
|
|
|
func main() {
|
|
var v1 value[int]
|
|
set(&v1, 1)
|
|
if got, want := get(&v1), 1; got != want {
|
|
panic(fmt.Sprintf("get() == %d, want %d", got, want))
|
|
}
|
|
|
|
v1.set(2)
|
|
if got, want := v1.get(), 2; got != want {
|
|
panic(fmt.Sprintf("get() == %d, want %d", got, want))
|
|
}
|
|
|
|
v1p := new(value[int])
|
|
set(v1p, 3)
|
|
if got, want := get(v1p), 3; got != want {
|
|
panic(fmt.Sprintf("get() == %d, want %d", got, want))
|
|
}
|
|
|
|
v1p.set(4)
|
|
if got, want := v1p.get(), 4; got != want {
|
|
panic(fmt.Sprintf("get() == %d, want %d", got, want))
|
|
}
|
|
|
|
var v2 value[string]
|
|
set(&v2, "a")
|
|
if got, want := get(&v2), "a"; got != want {
|
|
panic(fmt.Sprintf("get() == %q, want %q", got, want))
|
|
}
|
|
|
|
v2.set("b")
|
|
if got, want := get(&v2), "b"; got != want {
|
|
panic(fmt.Sprintf("get() == %q, want %q", got, want))
|
|
}
|
|
|
|
v2p := new(value[string])
|
|
set(v2p, "c")
|
|
if got, want := get(v2p), "c"; got != want {
|
|
panic(fmt.Sprintf("get() == %d, want %d", got, want))
|
|
}
|
|
|
|
v2p.set("d")
|
|
if got, want := v2p.get(), "d"; got != want {
|
|
panic(fmt.Sprintf("get() == %d, want %d", got, want))
|
|
}
|
|
}
|