mirror of
https://github.com/golang/go
synced 2024-11-18 17:04:41 -07:00
b4fe758a9b
DefaultOptions was a value type, but held map values. This CL changes it to a function that returns an Options value that has new instances of all reference types. It would be better if this function returned a pointer, but that change ended up being too large. I will need to refactor handling of options later anyway, in order to support sessions with differing options for golang.org/issues/34111. This fixes a race in internal/lsp/tests: internal/hooks/analysis.go mutates the Analyzers map. See for example the trybots result at: https://storage.googleapis.com/go-build-log/0d34f5f0/linux-amd64-race_4ecdf9c8.log Change-Id: I41be450b590a3f3104ac9a1cb9cb312ea3ff7ff4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/217077 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> |
||
|---|---|---|
| .. | ||
| apidiff | ||
| fastwalk | ||
| gopathwalk | ||
| imports | ||
| jsonrpc2 | ||
| lsp | ||
| memoize | ||
| module | ||
| packagesinternal | ||
| semver | ||
| span | ||
| telemetry | ||
| testenv | ||
| tool | ||
| xcontext | ||