mirror of
https://github.com/golang/go
synced 2024-11-18 13:34:41 -07:00
5cb1c80a83
Document a risk of generating invalid code due to shadowing between identifiers in code files and the imported package names. This risk was present before for any package with more than 1 .go file, but it's increased when some files have renamed imports (since they're typically used to resolve shadowing conflicts). Resolves TODO(adonovan): support renaming imports. Change-Id: Ie0e702345790fd2059c229623fb99fe645d688a4 Reviewed-on: https://go-review.googlesource.com/23785 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com>
73 lines
1.7 KiB
Go
73 lines
1.7 KiB
Go
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"io/ioutil"
|
|
"os"
|
|
"os/exec"
|
|
"runtime"
|
|
"testing"
|
|
|
|
"golang.org/x/tools/go/buildutil"
|
|
)
|
|
|
|
func TestBundle(t *testing.T) {
|
|
load := func(name string) string {
|
|
data, err := ioutil.ReadFile(name)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
return string(data)
|
|
}
|
|
|
|
ctxt = buildutil.FakeContext(map[string]map[string]string{
|
|
"initial": {
|
|
"a.go": load("testdata/src/initial/a.go"),
|
|
"b.go": load("testdata/src/initial/b.go"),
|
|
"c.go": load("testdata/src/initial/c.go"),
|
|
},
|
|
"domain.name/importdecl": {
|
|
"p.go": load("testdata/src/domain.name/importdecl/p.go"),
|
|
},
|
|
"fmt": {
|
|
"print.go": `package fmt; func Println(...interface{})`,
|
|
},
|
|
})
|
|
|
|
os.Args = os.Args[:1] // avoid e.g. -test=short in the output
|
|
out, err := bundle("initial", "github.com/dest", "dest", "prefix")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if got, want := string(out), load("testdata/out.golden"); got != want {
|
|
t.Errorf("-- got --\n%s\n-- want --\n%s\n-- diff --", got, want)
|
|
|
|
if err := ioutil.WriteFile("testdata/out.got", out, 0644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
t.Log(diff("testdata/out.golden", "testdata/out.got"))
|
|
}
|
|
}
|
|
|
|
func diff(a, b string) string {
|
|
var cmd *exec.Cmd
|
|
switch runtime.GOOS {
|
|
case "plan9":
|
|
cmd = exec.Command("/bin/diff", "-c", a, b)
|
|
default:
|
|
cmd = exec.Command("/usr/bin/diff", "-u", a, b)
|
|
}
|
|
var out bytes.Buffer
|
|
cmd.Stdout = &out
|
|
cmd.Stderr = &out
|
|
cmd.Run() // nonzero exit is expected
|
|
if out.Len() == 0 {
|
|
return "(failed to compute diff)"
|
|
}
|
|
return out.String()
|
|
}
|