1
0
mirror of https://github.com/golang/go synced 2024-09-30 22:48:32 -06:00
go/internal/lsp/cache
Rebecca Stambler b3d141ddef internal/lsp/cache: copy *packages.Config environment completely
I noticed a race in these logs:
https://build.golang.org/log/ec2915e97319de219284ed022338f2ebc549aff6.

We need to copy the environment and build flags for each config, since
we're treating the config as single use.

Change-Id: I9e717e688def088cb60f2b23b71d731e2b20b259
Reviewed-on: https://go-review.googlesource.com/c/tools/+/244118
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
2020-07-23 19:57:34 +00:00
..
analysis.go internal/memoize: add an error return to (*handle).Get 2020-06-24 16:33:19 +00:00
cache.go internal/lsp: don't keep track of closed overlays 2020-07-16 17:49:00 +00:00
check.go internal/lsp: refactor go.mod diagnostics to simplify the API 2020-07-16 22:50:03 +00:00
error_test.go internal/lsp: refactor error handling code in type-checking 2019-10-21 18:57:46 +00:00
errors.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
keys.go internal/lsp: decouple client and server debug 2020-06-11 13:49:48 +00:00
load.go internal/lsp: try to parse diagnostics out of go list errors 2020-07-21 22:03:47 +00:00
mod_tidy.go internal/lsp: support go mod tidy on save without diagnostics 2020-07-21 22:32:18 +00:00
mod.go internal/memoize: add an error return to (*handle).Get 2020-06-24 16:33:19 +00:00
os_darwin.go internal/lsp: add a mutex around the view's options 2020-04-02 16:41:49 +00:00
os_windows.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
parse.go internal/lsp/source: speed up completion candidate formatting 2020-07-01 04:11:22 +00:00
pkg.go internal/lsp/source: add a new symbolStyle configuration option 2020-06-26 17:13:37 +00:00
session.go internal/lsp: handle unknown revision in go.mod file 2020-07-21 21:40:18 +00:00
snapshot.go internal/lsp/cache: copy *packages.Config environment completely 2020-07-23 19:57:34 +00:00
view_test.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
view.go internal/lsp: handle unknown revision in go.mod file 2020-07-21 21:40:18 +00:00