mirror of
https://github.com/golang/go
synced 2024-11-18 23:05:06 -07:00
b28839e4bd
Features: More robust: silently ignore type errors in modes that don't need SSA form: describe, referrers, implements, freevars, description. This makes the tool much more robust for everyday queries. Less configuration: don't require a scope argument for all queries. Only queries that do pointer analysis need it. For the rest, the initial position is enough for importQueryPackage to deduce the scope. It now works for queries in GoFiles, TestGoFiles, or XTestGoFiles. (It no longer works for ad-hoc main packages like $GOROOT/src/net/http/triv.go) More complete: "referrers" computes the scope automatically by scanning the import graph of the entire workspace, using gorename's refactor/importgraph package. This requires two passes at loading. Faster: simplified start-up logic avoids unnecessary package loading and SSA construction (a consequence of bad abstraction) in many cases. "callgraph": remove it. Unlike all the other commands it isn't related to the current selection, and we have golang.org/x/tools/cmdcallgraph now. Internals: Drop support for long-running clients (i.e., Pythia), since godoc -analysis supports all the same features except "pointsto", and precomputes all the results so latency is much lower. Get rid of various unhelpful abstractions introduced to support long-running clients. Expand out the set-up logic for each subcommand. This is simpler, easier to read, and gives us more control, at a small cost in duplication---the familiar story of abstractions. Discard PTA warnings. We weren't showing them (nor should we). Split tests into separate directories (so that importgraph works). Change-Id: I55d46b3ab33cdf7ac22436fcc2148fe04c901237 Reviewed-on: https://go-review.googlesource.com/8243 Reviewed-by: David Crawshaw <crawshaw@golang.org>
197 lines
4.9 KiB
Go
197 lines
4.9 KiB
Go
// Copyright 2013 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package oracle
|
|
|
|
import (
|
|
"fmt"
|
|
"go/ast"
|
|
"go/token"
|
|
"sort"
|
|
|
|
"golang.org/x/tools/go/loader"
|
|
"golang.org/x/tools/go/pointer"
|
|
"golang.org/x/tools/go/ssa"
|
|
"golang.org/x/tools/go/types"
|
|
"golang.org/x/tools/oracle/serial"
|
|
)
|
|
|
|
// Callees reports the possible callees of the function call site
|
|
// identified by the specified source location.
|
|
func callees(q *Query) error {
|
|
lconf := loader.Config{Build: q.Build}
|
|
|
|
// Determine initial packages for PTA.
|
|
args, err := lconf.FromArgs(q.Scope, true)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if len(args) > 0 {
|
|
return fmt.Errorf("surplus arguments: %q", args)
|
|
}
|
|
|
|
// Load/parse/type-check the program.
|
|
lprog, err := lconf.Load()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
q.Fset = lprog.Fset
|
|
|
|
qpos, err := parseQueryPos(lprog, q.Pos, true) // needs exact pos
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
prog := ssa.Create(lprog, 0)
|
|
|
|
ptaConfig, err := setupPTA(prog, lprog, q.PTALog, q.Reflection)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
pkg := prog.Package(qpos.info.Pkg)
|
|
if pkg == nil {
|
|
return fmt.Errorf("no SSA package")
|
|
}
|
|
|
|
// Determine the enclosing call for the specified position.
|
|
var e *ast.CallExpr
|
|
for _, n := range qpos.path {
|
|
if e, _ = n.(*ast.CallExpr); e != nil {
|
|
break
|
|
}
|
|
}
|
|
if e == nil {
|
|
return fmt.Errorf("there is no function call here")
|
|
}
|
|
// TODO(adonovan): issue an error if the call is "too far
|
|
// away" from the current selection, as this most likely is
|
|
// not what the user intended.
|
|
|
|
// Reject type conversions.
|
|
if qpos.info.Types[e.Fun].IsType() {
|
|
return fmt.Errorf("this is a type conversion, not a function call")
|
|
}
|
|
|
|
// Reject calls to built-ins.
|
|
if id, ok := unparen(e.Fun).(*ast.Ident); ok {
|
|
if b, ok := qpos.info.Uses[id].(*types.Builtin); ok {
|
|
return fmt.Errorf("this is a call to the built-in '%s' operator", b.Name())
|
|
}
|
|
}
|
|
|
|
// Defer SSA construction till after errors are reported.
|
|
prog.BuildAll()
|
|
|
|
// Ascertain calling function and call site.
|
|
callerFn := ssa.EnclosingFunction(pkg, qpos.path)
|
|
if callerFn == nil {
|
|
return fmt.Errorf("no SSA function built for this location (dead code?)")
|
|
}
|
|
|
|
// Find the call site.
|
|
site, err := findCallSite(callerFn, e.Lparen)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
funcs, err := findCallees(ptaConfig, site)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
q.result = &calleesResult{
|
|
site: site,
|
|
funcs: funcs,
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func findCallSite(fn *ssa.Function, lparen token.Pos) (ssa.CallInstruction, error) {
|
|
for _, b := range fn.Blocks {
|
|
for _, instr := range b.Instrs {
|
|
if site, ok := instr.(ssa.CallInstruction); ok && instr.Pos() == lparen {
|
|
return site, nil
|
|
}
|
|
}
|
|
}
|
|
return nil, fmt.Errorf("this call site is unreachable in this analysis")
|
|
}
|
|
|
|
func findCallees(conf *pointer.Config, site ssa.CallInstruction) ([]*ssa.Function, error) {
|
|
// Avoid running the pointer analysis for static calls.
|
|
if callee := site.Common().StaticCallee(); callee != nil {
|
|
switch callee.String() {
|
|
case "runtime.SetFinalizer", "(reflect.Value).Call":
|
|
// The PTA treats calls to these intrinsics as dynamic.
|
|
// TODO(adonovan): avoid reliance on PTA internals.
|
|
|
|
default:
|
|
return []*ssa.Function{callee}, nil // singleton
|
|
}
|
|
}
|
|
|
|
// Dynamic call: use pointer analysis.
|
|
conf.BuildCallGraph = true
|
|
cg := ptrAnalysis(conf).CallGraph
|
|
cg.DeleteSyntheticNodes()
|
|
|
|
// Find all call edges from the site.
|
|
n := cg.Nodes[site.Parent()]
|
|
if n == nil {
|
|
return nil, fmt.Errorf("this call site is unreachable in this analysis")
|
|
}
|
|
calleesMap := make(map[*ssa.Function]bool)
|
|
for _, edge := range n.Out {
|
|
if edge.Site == site {
|
|
calleesMap[edge.Callee.Func] = true
|
|
}
|
|
}
|
|
|
|
// De-duplicate and sort.
|
|
funcs := make([]*ssa.Function, 0, len(calleesMap))
|
|
for f := range calleesMap {
|
|
funcs = append(funcs, f)
|
|
}
|
|
sort.Sort(byFuncPos(funcs))
|
|
return funcs, nil
|
|
}
|
|
|
|
type calleesResult struct {
|
|
site ssa.CallInstruction
|
|
funcs []*ssa.Function
|
|
}
|
|
|
|
func (r *calleesResult) display(printf printfFunc) {
|
|
if len(r.funcs) == 0 {
|
|
// dynamic call on a provably nil func/interface
|
|
printf(r.site, "%s on nil value", r.site.Common().Description())
|
|
} else {
|
|
printf(r.site, "this %s dispatches to:", r.site.Common().Description())
|
|
for _, callee := range r.funcs {
|
|
printf(callee, "\t%s", callee)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (r *calleesResult) toSerial(res *serial.Result, fset *token.FileSet) {
|
|
j := &serial.Callees{
|
|
Pos: fset.Position(r.site.Pos()).String(),
|
|
Desc: r.site.Common().Description(),
|
|
}
|
|
for _, callee := range r.funcs {
|
|
j.Callees = append(j.Callees, &serial.CalleesItem{
|
|
Name: callee.String(),
|
|
Pos: fset.Position(callee.Pos()).String(),
|
|
})
|
|
}
|
|
res.Callees = j
|
|
}
|
|
|
|
type byFuncPos []*ssa.Function
|
|
|
|
func (a byFuncPos) Len() int { return len(a) }
|
|
func (a byFuncPos) Less(i, j int) bool { return a[i].Pos() < a[j].Pos() }
|
|
func (a byFuncPos) Swap(i, j int) { a[i], a[j] = a[j], a[i] }
|