mirror of
https://github.com/golang/go
synced 2024-11-05 11:36:10 -07:00
5bf02b21f1
We keep track of the N highest seen scores so we can quickly skip deep completions not in the top N. Our logic for maintaining the top N list wasn't quite right, resulting in certain cases where we would let non-high scoring candidates through. I don't think the bug impacted correctness. Change-Id: Ic105617523c82f0e71e4f95ef0ee216182a84252 Reviewed-on: https://go-review.googlesource.com/c/tools/+/247418 Run-TryBot: Muir Manders <muir@mnd.rs> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
34 lines
776 B
Go
34 lines
776 B
Go
// Copyright 2020 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package source
|
|
|
|
import (
|
|
"testing"
|
|
)
|
|
|
|
func TestDeepCompletionIsHighScore(t *testing.T) {
|
|
// Test that deepCompletionState.isHighScore properly tracks the top
|
|
// N=MaxDeepCompletions scores.
|
|
|
|
var s deepCompletionState
|
|
|
|
if !s.isHighScore(1) {
|
|
// No other scores yet, anything is a winner.
|
|
t.Error("1 should be high score")
|
|
}
|
|
|
|
// Fill up with higher scores.
|
|
for i := 0; i < MaxDeepCompletions; i++ {
|
|
if !s.isHighScore(10) {
|
|
t.Error("10 should be high score")
|
|
}
|
|
}
|
|
|
|
// High scores should be filled with 10s so 2 is not a high score.
|
|
if s.isHighScore(2) {
|
|
t.Error("2 shouldn't be high score")
|
|
}
|
|
}
|