qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 16:14:46 -07:00
Code Releases Activity
ad473c03aa
go/internal/lsp
History
Rohan Challa ad473c03aa internal/lsp: add handling for go.mod files in internal/lsp functions 
When we are processing a go.mod file, we are calling go/packages.load
when we should not be. It will always return 0 packages since it is
not a .go file. This CL adds branching inside each internal/lsp protocol
function and also adds a check in snapshot.PackageHandles for the file type
and returns an error. This will prevent `go list` from running on go.mod files for now.

Updates golang/go#31999

Change-Id: Ic6d0e9b7c81e1f404342b98e10b9c5387adde2ee
Reviewed-on: https://go-review.googlesource.com/c/tools/+/210757
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rohan Challa <rohan@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-12-11 23:24:34 +00:00
..
browser internal/lsp: add version and bug commands 2019-05-11 04:16:02 +00:00
cache internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
cmd internal/lsp: make Text in DidSave request a pointer 2019-12-10 19:28:57 +00:00
debug internal/lsp: fix the debug info pages 2019-11-04 23:16:26 +00:00
diff internal/lsp: fix unified diffs of edits at the end of a file 2019-10-11 16:38:14 +00:00
fuzzy internal/lsp: fix fuzzy matcher inconsistency 2019-10-22 21:05:28 +00:00
protocol internal/lsp: Make Text in DidSave at *string rather than a string 2019-12-10 20:07:04 +00:00
snippet all: fix broken links to LSP specification 2019-10-02 18:32:53 +00:00
source internal/lsp/source: fix all types in resolveInvalid 2019-12-11 23:00:51 +00:00
telemetry internal/lsp: call load in (*session).NewView 2019-11-07 23:34:59 +00:00
testdata internal/lsp/source: fix all types in resolveInvalid 2019-12-11 23:00:51 +00:00
tests internal/lsp: tweak implementation tests 2019-12-06 20:40:35 +00:00
code_action.go internal/lsp: rename CheckPackageHandle to PackageHandle 2019-12-02 18:29:46 +00:00
command.go internal/lsp: fix panic in bestView 2019-11-16 21:44:31 +00:00
completion_test.go internal/lsp: fix variadic interface completion ranking 2019-11-18 05:14:29 +00:00
completion.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
definition.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
diagnostics.go internal/lsp: propagate and handle context cancellation errors 2019-12-05 22:50:56 +00:00
folding_range.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
format.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
general.go internal/lsp: return snapshot when creating a view 2019-12-05 13:33:17 +00:00
highlight.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
hover.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
implementation.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
link.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
lsp_test.go internal/lsp: tweak implementation tests 2019-12-06 20:40:35 +00:00
references.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
rename.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
reset_golden.sh internal/lsp: fix regeneration of golden files 2019-09-25 13:16:59 +00:00
server.go internal/lsp: don't run analyses on the entire view 2019-11-25 22:48:44 +00:00
signature_help.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
symbols.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
text_synchronization.go internal/lsp: invalidate workspace packages when go.mod file changes 2019-12-11 22:23:25 +00:00
watched_files.go internal/lsp: propagate and handle context cancellation errors 2019-12-05 22:50:56 +00:00
workspace.go internal/lsp: return snapshot when creating a view 2019-12-05 13:33:17 +00:00