mirror of
https://github.com/golang/go
synced 2024-11-17 11:34:48 -07:00
5322776215
This will improve liveness analysis slightly, the same logic as
isdirectiface curently does. In:
type T struct {
m map[int]int
}
v := T{}
v.m = make(map[int]int)
T is considered "fat", now it is not. So assigning to v.m is considered
to clobber the entire v.
This is follow up of CL 179057.
Change-Id: Id6b4807b8e8521ef5d8bcb14fedb6dceb9dbf18c
Reviewed-on: https://go-review.googlesource.com/c/go/+/179578
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
42 lines
963 B
Go
42 lines
963 B
Go
// errorcheck -0 -live -wb=0
|
|
|
|
// Copyright 2014 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// liveness tests with inlining ENABLED
|
|
// see also live.go.
|
|
|
|
package main
|
|
|
|
// issue 8142: lost 'addrtaken' bit on inlined variables.
|
|
|
|
func printnl()
|
|
|
|
//go:noescape
|
|
func useT40(*T40)
|
|
|
|
type T40 struct {
|
|
m map[int]int
|
|
}
|
|
|
|
func newT40() *T40 {
|
|
ret := T40{}
|
|
ret.m = make(map[int]int, 42) // ERROR "live at call to makemap: &ret$"
|
|
return &ret
|
|
}
|
|
|
|
func bad40() {
|
|
t := newT40() // ERROR "stack object ret T40$" "stack object .autotmp_[0-9]+ map.hdr\[int\]int$"
|
|
printnl() // ERROR "live at call to printnl: ret$"
|
|
useT40(t)
|
|
}
|
|
|
|
func good40() {
|
|
ret := T40{} // ERROR "stack object ret T40$"
|
|
ret.m = make(map[int]int, 42) // ERROR "stack object .autotmp_[0-9]+ map.hdr\[int\]int$"
|
|
t := &ret
|
|
printnl() // ERROR "live at call to printnl: ret$"
|
|
useT40(t)
|
|
}
|