mirror of
https://github.com/golang/go
synced 2024-11-14 13:40:30 -07:00
9f89edcd96
In general, a conversion to interface type may require values to be boxed, which in turn necessitates escape analysis to determine whether the boxed representation can be stack allocated. However, esc.go used to unconditionally print escape analysis decisions about OCONVIFACE, even for conversions that don't require boxing (e.g., pointers, channels, maps, functions). For test compatibility with esc.go, escape.go similarly printed these useless diagnostics. This CL removes the diagnostics, and updates test expectations accordingly. Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12 Reviewed-on: https://go-review.googlesource.com/c/go/+/192697 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
109 lines
1.8 KiB
Go
109 lines
1.8 KiB
Go
// errorcheck -0 -m -l
|
|
|
|
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test indirection level computation in escape analysis.
|
|
|
|
package escape
|
|
|
|
var sink interface{}
|
|
|
|
func level0() {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
p0 := &i // ERROR "moved to heap: p0"
|
|
p1 := &p0 // ERROR "moved to heap: p1"
|
|
p2 := &p1 // ERROR "moved to heap: p2"
|
|
sink = &p2
|
|
}
|
|
|
|
func level1() {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
p0 := &i // ERROR "moved to heap: p0"
|
|
p1 := &p0 // ERROR "moved to heap: p1"
|
|
p2 := &p1
|
|
sink = p2
|
|
}
|
|
|
|
func level2() {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
p0 := &i // ERROR "moved to heap: p0"
|
|
p1 := &p0
|
|
p2 := &p1
|
|
sink = *p2
|
|
}
|
|
|
|
func level3() {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
p0 := &i
|
|
p1 := &p0
|
|
p2 := &p1
|
|
sink = **p2
|
|
}
|
|
|
|
func level4() {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
p0 := &i // ERROR "moved to heap: p0"
|
|
p1 := &p0
|
|
p2 := p1 // ERROR "moved to heap: p2"
|
|
sink = &p2
|
|
}
|
|
|
|
func level5() {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
p0 := &i // ERROR "moved to heap: p0"
|
|
p1 := &p0
|
|
p2 := p1
|
|
sink = p2
|
|
}
|
|
|
|
func level6() {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
p0 := &i
|
|
p1 := &p0
|
|
p2 := p1
|
|
sink = *p2
|
|
}
|
|
|
|
func level7() {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
p0 := &i
|
|
p1 := &p0
|
|
// note *p1 == &i
|
|
p2 := *p1 // ERROR "moved to heap: p2"
|
|
sink = &p2
|
|
}
|
|
|
|
func level8() {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
p0 := &i
|
|
p1 := &p0
|
|
p2 := *p1
|
|
sink = p2
|
|
}
|
|
|
|
func level9() {
|
|
i := 0
|
|
p0 := &i
|
|
p1 := &p0
|
|
p2 := *p1
|
|
sink = *p2 // ERROR "\*p2 escapes to heap"
|
|
}
|
|
|
|
func level10() {
|
|
i := 0
|
|
p0 := &i
|
|
p1 := *p0
|
|
p2 := &p1
|
|
sink = *p2 // ERROR "\*p2 escapes to heap"
|
|
}
|
|
|
|
func level11() {
|
|
i := 0
|
|
p0 := &i
|
|
p1 := &p0
|
|
p2 := **p1 // ERROR "moved to heap: p2"
|
|
sink = &p2
|
|
}
|