mirror of
https://github.com/golang/go
synced 2024-11-14 06:40:22 -07:00
90a8482a17
I made the default be that, where there are differences between types2 and -G=0 error messages, we want errorcheck tests to pass types2. Typically, we can get errorcheck to pass on types2 and -G=0 if they give the same number of error messages on the same lines, just different wording. If they give a different number of error messages, then I made types2 pass. I added an exception list for -G=0 to cover those cases where -G=0 and types give different numbers of error messages. Because types2 does not run if there are syntax errors, for several tests, I had to split the tests into two parts in order to get all the indicated errors to be reported in types2 (bug228.go, bug388.go, issue11610.go, issue14520.go) I tried to preserve the GCCGO labeling correctly (but may have gotten some wrong). When types2 now matches where a GCCGO error previously occurred, I transformed GCCGO_ERROR -> ERROR. When types2 no longer reports an error in a certain place, I transformed ERROR -> GCCGO_ERROR. When types2 reports an error in a new place, I used GC_ERROR. The remaining entries in types2Failures are things that I think we probably still need to fix - either actually missing errors in types2, or cases where types2 gives worse errors than -G=0. Change-Id: I7f01e82b322b16094096b67d7ed2bb39b410c34f Reviewed-on: https://go-review.googlesource.com/c/go/+/372854 Trust: Dan Scales <danscales@google.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
57 lines
2.4 KiB
Go
57 lines
2.4 KiB
Go
// errorcheck
|
|
|
|
// Copyright 2013 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// issue 4232
|
|
// issue 7200
|
|
|
|
package p
|
|
|
|
func f() {
|
|
var a [10]int
|
|
_ = a[-1] // ERROR "invalid array index -1|index out of bounds|must not be negative"
|
|
_ = a[-1:] // ERROR "invalid slice index -1|index out of bounds|must not be negative"
|
|
_ = a[:-1] // ERROR "invalid slice index -1|index out of bounds|must not be negative"
|
|
_ = a[10] // ERROR "invalid array index 10|index .*out of bounds"
|
|
_ = a[9:10]
|
|
_ = a[10:10]
|
|
_ = a[9:12] // ERROR "invalid slice index 12|index .*out of bounds"
|
|
_ = a[11:12] // ERROR "invalid slice index 11|index .*out of bounds"
|
|
_ = a[1<<100 : 1<<110] // ERROR "overflows int|integer constant overflow|invalid slice index 1 << 100|index out of bounds"
|
|
|
|
var s []int
|
|
_ = s[-1] // ERROR "invalid slice index -1|index .*out of bounds|must not be negative"
|
|
_ = s[-1:] // ERROR "invalid slice index -1|index .*out of bounds|must not be negative"
|
|
_ = s[:-1] // ERROR "invalid slice index -1|index .*out of bounds|must not be negative"
|
|
_ = s[10]
|
|
_ = s[9:10]
|
|
_ = s[10:10]
|
|
_ = s[9:12]
|
|
_ = s[11:12]
|
|
_ = s[1<<100 : 1<<110] // ERROR "overflows int|integer constant overflow|invalid slice index 1 << 100|index out of bounds"
|
|
|
|
const c = "foofoofoof"
|
|
_ = c[-1] // ERROR "invalid string index -1|index out of bounds|must not be negative"
|
|
_ = c[-1:] // ERROR "invalid slice index -1|index out of bounds|must not be negative"
|
|
_ = c[:-1] // ERROR "invalid slice index -1|index out of bounds|must not be negative"
|
|
_ = c[10] // ERROR "invalid string index 10|index .*out of bounds"
|
|
_ = c[9:10]
|
|
_ = c[10:10]
|
|
_ = c[9:12] // ERROR "invalid slice index 12|index .*out of bounds"
|
|
_ = c[11:12] // ERROR "invalid slice index 11|index .*out of bounds"
|
|
_ = c[1<<100 : 1<<110] // ERROR "overflows int|integer constant overflow|invalid slice index 1 << 100|index out of bounds"
|
|
|
|
var t string
|
|
_ = t[-1] // ERROR "invalid string index -1|index out of bounds|must not be negative"
|
|
_ = t[-1:] // ERROR "invalid slice index -1|index out of bounds|must not be negative"
|
|
_ = t[:-1] // ERROR "invalid slice index -1|index out of bounds|must not be negative"
|
|
_ = t[10]
|
|
_ = t[9:10]
|
|
_ = t[10:10]
|
|
_ = t[9:12]
|
|
_ = t[11:12]
|
|
_ = t[1<<100 : 1<<110] // ERROR "overflows int|integer constant overflow|invalid slice index 1 << 100|index out of bounds"
|
|
}
|